Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oscal content so that it only runs on develop and main #255

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

wandmagic
Copy link
Contributor

Committer Notes

{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@wandmagic
Copy link
Contributor Author

@iMichaela let me know once you have a chance to look at this

@david-waltermire
Copy link
Contributor

This seems to be atypical for a continuous integration approach where the philosophy is to test that every commit is verified for correctness. Why not enable these validation checks to run on personal and feature branches to find issues early before they are merged into develop?

@iMichaela
Copy link
Contributor

iMichaela commented Jul 11, 2024

The PR is from March when @wandmagic was working on examples for the prototype models. The intention is to allow for development of content (examples) for the prototype models (not released) and not incorporated in the oscal-cli. We still have that need. With that said, I did not approve it because I wanted to take a different approach than the proposed one: to NOT run the tests and validations automatically on prototype-* branch but run on all others. I just did not have the cycle to get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants