Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for child containers and initialization after view init #647

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

d1820
Copy link

@d1820 d1820 commented Apr 1, 2017

With these changes, ngDragula will work with other 3rd party components where access to placing the directive on the element is not possible. A good example of this is working with ngPrime.

Added support for delayed initialization
@codecov-io
Copy link

codecov-io commented Apr 1, 2017

Codecov Report

Merging #647 into master will decrease coverage by 1.61%.
The diff coverage is 23.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage    44.7%   43.09%   -1.62%     
==========================================
  Files           9        9              
  Lines         170      181      +11     
  Branches       17       20       +3     
==========================================
+ Hits           76       78       +2     
- Misses         94      103       +9
Impacted Files Coverage Δ
src/components/dragula.directive.ts 31.11% <23.8%> (-4.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ce361...1ff7d75. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants