Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-upload in a single request #993

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

koenvanderlinden
Copy link

Feature to upload all files using one multipart request.

Let me know what you think of it.

@codecov
Copy link

codecov bot commented Mar 17, 2018

Codecov Report

Merging #993 into development will decrease coverage by 0.86%.
The diff coverage is 10.34%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #993      +/-   ##
===============================================
- Coverage        34.72%   33.85%   -0.87%     
===============================================
  Files               10       10              
  Lines              550      570      +20     
  Branches            80       81       +1     
===============================================
+ Hits               191      193       +2     
- Misses             341      359      +18     
  Partials            18       18
Impacted Files Coverage Δ
src/file-upload/file-uploader.class.ts 23.23% <10.34%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb48f44...95d5778. Read the comment docs.

@adrianfaciu
Copy link

I just had a quick view, not much free time for me right now, but it looks good.
However most people (me included) use this library with AOT so we kind of need to make it work with that.

As a tip, you could use git rebase to squash the commits together.

Maybe @valorkin or @buchslava can provide more assistance.

@koenvanderlinden
Copy link
Author

Thanks for having a look and some tips.
About the AOT. The original sourcecode gave me the same errors, so the changes in this Pull are not the root-cause of my build failing with AOT.
I case someone has some spare time, the --aot param can be added again to see what happens.

@ar27111994
Copy link

When will this get merged?

@ar27111994 ar27111994 mentioned this pull request Jan 19, 2019
@eikishi01
Copy link

I was just looking for a way to upload all files individually and I got to this PR finding out that it is the default behaviour, which is what I needed, @koenvanderlinden does you PR consider allowing the use of both approaches? both use cases are valid and it should count for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants