Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate invocation of error handler #2667

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Prevent duplicate invocation of error handler #2667

merged 1 commit into from
Oct 24, 2024

Conversation

ljpengelen
Copy link
Contributor

Motivation:

Backport of #2662 and #2666.

@ljpengelen
Copy link
Contributor Author

As far as I can see, the test failure is not caused by the changes in this PR. There seems to be something wrong with CSRFHandlerTest#simultaneousGetAndPostDoesNotOverrideTokenInSession. On my machine, it fails when I run it in isolation, but succeeds when its executed together with the other tests in the class CSRFHandlerTest.

@ljpengelen ljpengelen mentioned this pull request Oct 23, 2024
Merged
@vietj
Copy link
Contributor

vietj commented Oct 24, 2024

can you rebase on master ? thanks for cherry picking also the change I did after.

@vietj
Copy link
Contributor

vietj commented Oct 24, 2024

thanks @ljpengelen

@vietj vietj merged commit c809fcc into vert-x3:4.x Oct 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljpengelen @vietj