fix(#2283): Prevent MultipartFormUpload PostRequestEncoder including transfer-encoding:chunked #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch is illegal in HTTP2 and HTTP3. Apply a simple fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently,
MultipartFormUploadusesPostRequestEncoderwhich includestransfer-encodingheaders which are illegal in HTTP2 and HTTP3 as per the RFC.Currently it is a simple fix, maybe this should be improved from the
nettyside itself to prevent needing to rewrite/polyfill the entirePostRequestEncoderjust for such a small thing.Fixes #2283
Side note: When testing, I noticed that the
MultipartFormUploaddoes not report any exceptions. If theres a failure in any of the handlers, the context is unaware. Is that intentional?