copyright pes header flag - desc 06a reserved flags fix - desc 38 and 3f support - AU_Information #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nriviera
changed the title
nriviera
commented
Oct 28, 2019
nriviera
changed the title
nriviera
changed the title
nriviera
changed the title
cmassiot
requested changes
Nov 13, 2019
|
Hi, is there anything still wrong with the pull request ? |
|
You should really rebase and squash the commits that make sense. Especially the fixup and revert ones. |
|
I agree with JB, otherwise it's good. |
* Add RTP Payload Format for JPEG (rfc2435) * dvb/si/sdt: fix consistency check between sections Spotted by Dmitriy Novash. * ethernet: Add 802.1q VLAN tag * Fix ATSC desc81_bit_rate_code_from_octetrate Co-authored-by: Josh de Kock <[email protected]> Co-authored-by: Christophe Massiot <[email protected]> Co-authored-by: Kieran Kunhya <[email protected]> Co-authored-by: Arnaud de Turckheim <[email protected]>
comments revert to include in another commit fixed as per revision
* Add RTP Payload Format for JPEG (rfc2435) * dvb/si/sdt: fix consistency check between sections Spotted by Dmitriy Novash. * ethernet: Add 802.1q VLAN tag * Fix ATSC desc81_bit_rate_code_from_octetrate Co-authored-by: Josh de Kock <[email protected]> Co-authored-by: Christophe Massiot <[email protected]> Co-authored-by: Kieran Kunhya <[email protected]> Co-authored-by: Arnaud de Turckheim <[email protected]>
|
I did the squash and rebase. |
|
Hi, the commit list seems wrong: several commits are there twice. Also there is now a conflict to fix. Can you check this? Thanks |
ghost
approved these changes
Sep 17, 2020
lawchingman
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for copyright pes header flag