Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unicode display #96

Merged
merged 1 commit into from
May 26, 2024
Merged

fix unicode display #96

merged 1 commit into from
May 26, 2024

Conversation

kanlac
Copy link
Contributor

@kanlac kanlac commented May 21, 2024

  • I've read Contribution guide
  • I've tested everything that doesn't relate to tcell.Screen API

Close #76.

Compared to adding extra blank runes (#77), I think a more reasonable way is to fix the implementation of GetCell.

@viktomas
Copy link
Owner

Thank you @kanlac 🙏

The implementation makes sense to me, can you please add to your PR description a test case that I can try with the current version and then with your PR to see this change in action?

Once I manually re-test this, the PR is good to go

@kanlac
Copy link
Contributor Author

kanlac commented May 26, 2024

Sure, it's easy to reproduce. You can create a file or directory with Unicode characters, for example mkdir 测试目录, and then run godu -l 0. You will see that the second and fourth characters are missing.
image

After this PR change, the file names will display correctly:
image

@viktomas
Copy link
Owner

Thank you @kanlac, I tested this locally, and it works well 👍

@viktomas viktomas merged commit 54765d1 into viktomas:main May 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unicode support
2 participants