Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmp-serde support & docs for features #71

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

leontoeides
Copy link

  • Housekeeping: removed extra unnecessary Sized bounds already declared in the trait
  • Support for rmp-serde
  • Visibility to feature-gated codecs in the docs.

@vincent-herlemont
Copy link
Owner

@leontoeides thanks you very much for your PR!

Can you re-write your commit names with the conventionalcommits format? To do it you can use git rebase -i <...> and use the reword keyword to rewrite commit message.

@leontoeides
Copy link
Author

Yes, I made quite a mess with all the commits. My git skills are the bare minimum. But, thanks, today I learned that there is a way to clean these types of messes up. There is a way to "squash" commits together, but I'm thinking it might be too late for that? I'm seeing your commits in my squash list. Seems dangerous. I hope this works well enough

@vincent-herlemont
Copy link
Owner

Yes, I made quite a mess with all the commits. My git skills are the bare minimum. But, thanks, today I learned that there is a way to clean these types of messes up. There is a way to "squash" commits together, but I'm thinking it might be too late for that? I'm seeing your commits in my squash list. Seems dangerous. I hope this works well enough

@leontoeides Thank you for renaming the commit; it's the "right way to do it." However, keep in mind that it depends on the project. In fact, everyone does as they wish/can.

But now, I have the impression that there was a problem during the rebase (unresolved git conflicts) which is causing issues in your code. For example Cargo.toml#L19-L29. These conflicts can be long and tedious to fix. Well, I can suggest something because I don't want us to lose your work:

I saw that in your PR, you were trying to do several things: adding documentation, fixing the documentation of features (related to this issue #70), adding custom encode/decode rmp_serde_1_3, and other small things. What I can propose to make things simpler for you and to avoid having to perform complicated git manipulations is to: Create a branch for each task, for example, add_custom_encode_decode_rmp_serde_1_3 and do only what the name of the branch indicates. And make a PR for each thing, you can then close this PR #71 subsequently. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the Rust documentation for the available custom encoders/decoders
2 participants