-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to install on many OS using Travis and docker. #61
base: master
Are you sure you want to change the base?
Conversation
install: | ||
- [[ $TRAVIS_OS_NAME == "osx" ]] && docker run -d $OS /bin/sh -c "$INSTALL_REQUIREMENTS" | ||
- [[ $TRAVIS_OS_NAME == "linux" ]] && docker run -d $OS /bin/sh -c "$INSTALL_REQUIREMENTS" | ||
- docker run -d $OS /bin/sh -c "sudo wget https://github.com/EspaceNetworks/virtualmin-install/raw/master/virtualmin-install.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not hard code to your repository.
Are we able to use checked out file in source directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Have to look up the runtime variable in travis for "the URL to a file in the current checked out source we're running this test on" so that it'd work right from everywhere.
Assuming I'm able to get Travis CI connected to our repos again, I would like to start with one (1!) OS test first. There's absolutely no way the vast majority of these distros or OSes are going to work at first. Make it do something useful on one OS (a supported one) before throwing the whole dang kitchen at it. |
- [[ $TRAVIS_OS_NAME == "linux" ]] && docker pull ${OS_TYPE} | ||
|
||
install: | ||
- [[ $TRAVIS_OS_NAME == "osx" ]] && docker run -d $OS /bin/sh -c "$INSTALL_REQUIREMENTS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which value will be set for $OS
variable?
If it is a linux distribution name (such as ubuntu:22.04
), we don't need to run onosx
env, which cost more credits than usual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, there is absolutely 100% no way I'm ever going to support MacOS. I spent weeks messing about with it several years ago, and it's not worth it (and the days of MacOS on a server are over, if they ever existed...they didn't really, but Apple did used to make servers). Besides that, the best "package manager" on MacOS is allegedly Homebrew, which is a disaster, especially for servers.
Can we reduce the amount of OS, to let's say one (for now), like Alma or Rocky, and also try to run Bedies, is there a way to leave and also run old tests, like |
No description provided.