feat(i3s): Add an option to multiply colors by attribute #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkuznetsov-actionengine
changed the title
belom88
approved these changes
Jun 21, 2023
ibgreen
approved these changes
Jun 26, 2023
| if (options.i3s.colorsByAttribute.mode === 'multiply') { | ||
| const multupliedColor = colors.value.subarray(i * 4, i * 4 + 3); | ||
| for (let j = 0; j < 4; j++) { | ||
| multupliedColor[j] = (multupliedColor[j] * color[j]) / 255; |
There was a problem hiding this comment.
Typo
Suggested change
| multupliedColor[j] = (multupliedColor[j] * color[j]) / 255; | |
| multipliedColor[j] = (multipliedColor[j] * color[j]) / 255; |
There was a problem hiding this comment.
Fixed
| /* eslint max-statements: ["error", 30] */ | ||
| /* eslint complexity: ["error", 12] */ | ||
| if (options.i3s.colorsByAttribute.mode === 'multiply') { | ||
| const multupliedColor = colors.value.subarray(i * 4, i * 4 + 3); |
There was a problem hiding this comment.
Nit: Generates a lot of small objects, perf / GC.
What happens if you just multiply all elements in the array "in situ"?
There was a problem hiding this comment.
It will be working fine, fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@belom88 Please review