feat(converter): support writing 3DTILES of version 1.1 #3054
Conversation
mspivak-actionengine
requested review from
belom88 and
dariaterekhova-actionengine
| _checkNormals(normals) { | ||
| // If all normals === 0, the resulting tileset is all in black colors on Cesium | ||
| return normals.find((value) => value); | ||
| export default class B3dmConverter extends TilesConverter { |
There was a problem hiding this comment.
Do we need these subclasses? They don't do much... Maybe just instantiate the TilesConverter with the different version numbers.
| @@ -0,0 +1,354 @@ | |||
| /* eslint-disable no-console */ | |||
|
|
|||
| import type {I3STileContent, FeatureAttribute} from '@loaders.gl/i3s'; | |||
There was a problem hiding this comment.
Because this became a completely new file, it is not possible to easily see what has changed.
|
@mspivak-actionengine correct me if needed |
modules/tile-converter/src/3d-tiles-converter/helpers/gltf-converter.ts
Outdated
Show resolved
Hide resolved
modules/tile-converter/src/3d-tiles-converter/3d-tiles-converter.ts
Outdated
Show resolved
Hide resolved
modules/tile-converter/src/3d-tiles-converter/3d-tiles-converter.ts
Outdated
Show resolved
Hide resolved
modules/tile-converter/src/3d-tiles-converter/helpers/gltf-converter.ts
Outdated
Show resolved
Hide resolved
modules/tile-converter/src/3d-tiles-converter/helpers/gltf-converter.ts
Outdated
Show resolved
Hide resolved
modules/tile-converter/src/3d-tiles-converter/helpers/gltf-converter.ts
Outdated
Show resolved
Hide resolved
modules/tile-converter/src/3d-tiles-converter/helpers/gltf-converter.ts
Outdated
Show resolved
Hide resolved
modules/tile-converter/src/3d-tiles-converter/3d-tiles-converter.ts
Outdated
Show resolved
Hide resolved
modules/tile-converter/test/3d-tiles-converter/helpers/b3dm-converter.spec.js
Show resolved
Hide resolved
modules/tile-converter/test/3d-tiles-converter/helpers/b3dm-converter.spec.js
Outdated
Show resolved
Hide resolved
| values: [] | ||
| }; | ||
| if (isTypedArray(attributeValues)) { | ||
| propertyAttribute.values = Array.prototype.slice.call(attributeValues); |
There was a problem hiding this comment.
I don't think this code is correct. Function.prototype.call() expects thisArg as the first parameter. Use Array.from(attributeValues) to convert a typed array to a JS array
No description provided.