test: css addWatchFile in load hook #18103
Open
+70
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a failing test for CSS that relies on the
load
hook and callsthis.addWatchFile
there, which doesn't work currently (in v6 only).The reason is because of here:
vite/packages/vite/src/node/server/pluginContainer.ts
Lines 196 to 204 in ba56cf4
The
module
does not exist until theload
hook finishes here:vite/packages/vite/src/node/server/transformRequest.ts
Lines 338 to 340 in ba56cf4
I'm not entirely sure why it worked in v5 yet (for SPA only). But for SSR, I know that since the module nodes are shared, the pluginContainer can share the client module node after ssr already created the module node.