fix: asset new URL(,import.meta.url) match

[sapphi-red]

Description

Glob generated from new URL(, import.meta.url) was wrong.

For example, new URL(`./foo/${foo}.js`) was tranformed into ./foo/**.js and this glob does not match ./foo/bar/baz.js and only matches JS files in foo directory.

These are the examples of how some glob matches:

# /foo/**.js
- /foo/foo.js: true
- /foo/dir/foo.js: false

# /foo/**/*.js
- /foo/foo.js: true
- /foo/dir/foo.js: true

# /foo/****.js
- /foo/foo.js: true
- /foo/dir/foo.js: false

# /foo/**/foo.js
- /foo/foo.js: true
- /foo/dir/foo.js: true

# /foo/****/foo.js
- /foo/foo.js: false
- /foo/dir/foo.js: false

https://stackblitz.com/edit/node-b5czun?file=index.js

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sapphi-red]

Before this PR, this was ./foo/**.js.

[sapphi-red]

Before this PR, this was ./foo/****.js.

[sapphi-red]

Before this PR, this was ./foo/****/index.js.

[hi-ogawa]

Is it intended for new URL(`./foo/${key}.js`) to match nested ones like ./foo/bar/baz.js? I'm comparing it with dynamic import variable like import("./foo/${key}.js") and this seems to only match ./foo/bar.js.

[sapphi-red]

I made it match with nested files as I thought that was the intention of the original code. But I'm fine with making it only matching non-nested files.

[hi-ogawa]

I'm not sure about the history, but matching only non-nested makes more sense to me as I assume that aligns closer with dynamic import var and also it's less likely to break existing usages.

[sapphi-red]

I've updated to use * instead of **. Though I said it's not a breaking change in the team meeting, I noticed that this is actually a breaking change as new URL(`./foo/${foo}/index.js`, import.meta.url) no longer matches ./foo/bar/baz/index.js.

[sapphi-red]

The test was failing because of a different reason (It was not caused by the ** -> * change). It should be passing now.