refactor: break circular dependencies to fix test-unit #18237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/environment.ts` breaks the following circular dependecy: config.ts -> server/environments/runnableEnvironment.ts -> server/environment.ts -> config.ts
breaks the following circular dependency: server/environment.ts -> plugins/optimizeDeps.ts -> optimizer/index.ts -> optimizer/esbuildDepPlugin.ts -> plugins/css.ts -> build.ts -> config.ts -> server/environments/runnableEnvironment.ts -> server/environment.ts
|
|
patak-dev
reviewed
Sep 30, 2024
Comment on lines
34
to
46
| export function getDefaultResolvedEnvironmentOptions( | ||
| config: ResolvedConfig, | ||
| ): ResolvedEnvironmentOptions { | ||
| return { | ||
| define: config.define, | ||
| resolve: config.resolve, | ||
| consumer: 'server', | ||
| webCompatible: false, | ||
| dev: config.dev, | ||
| build: config.build, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think it is better to move this one level up to /node/baseEnvironment so we don't need to include /server/ from build.ts
patak-dev
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some circular dependency in the code base was making the tests fail locally. This PR removes the circular dependencies to fix it.
related: https://discord.com/channels/804011606160703521/804439875226173480/1290196030847057961
Please check each commit message to see what circular dependency is removed.