Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeql action upgrade #3903

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

chenejac
Copy link
Contributor

@chenejac chenejac commented Jul 28, 2023

VIVO GitHub issue: 3902

What does this pull request do?

Upgrading the codeql-action version (v1 is deprecated, it is upgraded to v2)

What's new?

codeql-analysis.yml files is slightly changed

How should this be tested?

https://github.com/vivo-project/VIVO/actions/runs/5690776782 there shouldn't be errors present in the previous running of codeql action, such as https://github.com/vivo-project/VIVO/actions/runs/5630429939

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

@chenejac chenejac linked an issue Jul 28, 2023 that may be closed by this pull request
@chenejac
Copy link
Contributor Author

Should I also upgrade :
actions/checkout@v2
with
actions/checkout@v3

Source - https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-versioned-actions

This should be remove warning present at https://github.com/vivo-project/VIVO/actions/runs/5690776782

@chenejac chenejac requested a review from a user July 28, 2023 10:17
@chenejac chenejac merged commit 9dc8f80 into vivo-project:main Sep 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeQL GitHub action is broken
2 participants