-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended search #382
Extended search #382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg thanks for this PR. It looks very nice. It works as it is described. I have posted a couple of comments. Besides those comments, I have also one additional remark:
- Should we include in the codebase some searchSettings.n3? It might be really basic one, and also provide some additional documentation at wiki how to customize the search page. I am afraid if we don't have that basic configuration included, the VIVO customers wouldn't be aware and wouldn't use this new functionality.
webapp/src/main/webapp/templates/freemarker/page/partials/remote-search.ftl
Outdated
Show resolved
Hide resolved
...pp/src/main/webapp/templates/freemarker/body/extendedsearch/extended-search-pagedResults.ftl
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/tbox/firsttime/classGroupAnnotationsVitro.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/en_US/tbox/firsttime/searchOntology.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/en_US/interface-i18n/firsttime/vitro_extended_search.ttl
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchFiltering.java
Outdated
Show resolved
Hide resolved
...c/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/ExtendedSearchController.java
Outdated
Show resolved
Hide resolved
I think we should create and add one. Maybe as an update to VIVO PR. |
0e325e7
to
5e7fab6
Compare
5e7fab6
to
4b05a1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg Export of search results includes only the first page results (usually 30 results) in both format csv and xml. Besides that I have added a couple of more minor comments.
home/src/main/resources/rdf/i18n/en_US/tbox/firsttime/searchOntology.n3
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/tbox/firsttime/classGroupAnnotationsVitro.n3
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/VitroSearchTermNames.java
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java
Outdated
Show resolved
Hide resolved
Fixed export in csv and xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg well done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works as expected! I have some tiny suggestions that you can maybe take into consideration.
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchFilter.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchFilterGroup.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/solr/SolrFieldInitializer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg well done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great. Good job!
VIVO PR
What does this pull request do?
Introduces extended search to Vitro
What's new?
Added extended search controller
Added search ontology
Created search class group
Bootstrap migrated from VIVO tenderfoot theme
Modified freemarker files to support extended search.
Solr field type dateRange and dynamic field *_drsim should be created on startup
How should this be tested?
Check logs to verify that field type dateRange and dynamic field *_drsim has been created on startup
[SolrFieldInitializer] Solr field type 'dateRange' not found. Trying to create.
[SolrFieldInitializer] Solr field type 'dateRange' has been created.
[SolrFieldInitializer] Solr dynamic field '*_drsim' of type dateRange not found. Trying to create.
[SolrFieldInitializer] Solr dateRange dynamic field '*_drsim' has been created.
Add sample data and example search settings attached below
example-search-settings.nt.zip
Try search, create new document modifiers, search filters
Notes
Additional Solr field configuration (autocreated on startup)
<dynamicField name="*_drsim" type="dateRange" stored="true" indexed="true" multiValued="true"/>
<fieldType name="dateRange" class="solr.DateRangeField"/>
New dependencies
js: noUiSlider
js: wnumb
Interested parties
@VIVO-project/vivo-committers
@chenejac