Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minisign ed25519 public-key signatures #546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Duncaen
Copy link
Member

@Duncaen Duncaen commented Feb 25, 2023

No description provided.

@Duncaen Duncaen force-pushed the minisign branch 3 times, most recently from 9056606 to ffbefa2 Compare February 25, 2023 18:55
@Duncaen Duncaen changed the title lib/crypto.c: add minisign ed25519 public-key cryptography api minisign ed25519 public-key signatures Feb 25, 2023
@Duncaen Duncaen changed the title minisign ed25519 public-key signatures Add minisign ed25519 public-key signatures Feb 25, 2023
break;
}
va_end(ap);
return r;

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable

The variable [r](1) may not be initialized at this access.
@Duncaen Duncaen force-pushed the minisign branch 8 times, most recently from 48c1a45 to f4c7d66 Compare February 26, 2023 17:02
}
if (!sig_file) {
snprintf(sigfile_buf, sizeof(sigfile_buf), "%s.minisig", msg_file);
sig_file = sigfile_buf;

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory

A stack address ([source](1)) may be assigned to a non-local variable.

if (!sig_file) {
snprintf(sigfile_buf, sizeof(sigfile_buf), "%s.minisig", msg_file);
sig_file = sigfile_buf;

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory

A stack address ([source](1)) may be assigned to a non-local variable.
}
}
if (b64_end != NULL) {
*b64_end = &b64[b64_pos];

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory

A stack address which arrived via a [parameter](1) may be assigned to a non-local variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant