Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop removed API attribute quote from FileCitation #113

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

amureki
Copy link
Member

@amureki amureki commented Jul 12, 2024

OpenAI broke their library (>v1.33), it does not reflect their API:
openai/openai-python#1498
This addresses https://voiio.sentry.io/issues/2046357/events/b726ec8de7e14bd896e26d57b88249a5/

Since quote is not really needed here, dropping it.

@amureki amureki requested a review from codingjoe July 12, 2024 13:47
@amureki amureki self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.57%. Comparing base (765bb25) to head (604be50).

Files Patch % Lines
sam/bot.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          19       19           
  Lines         610      610           
=======================================
  Hits          583      583           
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the line that causes the trouble. We don't need the quote.

@amureki amureki requested a review from codingjoe July 12, 2024 14:02
@amureki amureki changed the title Pin openai version to address broken API Drop removed API attribute quote from FileCitation Jul 12, 2024
@amureki amureki enabled auto-merge (squash) July 12, 2024 14:04
sam/bot.py Outdated Show resolved Hide resolved
@amureki amureki merged commit 147ae0a into main Jul 12, 2024
5 checks passed
@amureki amureki deleted the pin-openai branch July 12, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants