-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling Redis SSL verification for rediss
schema
#129
Conversation
eb15776
to
4480ebe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That URL scheme is natively supported https://github.com/redis/redis-py/blob/2e46613dcdf9db7f948f3258fee1c9199da8cbfa/redis/connection.py#L1163
@codingjoe you are right, but I did not finish working on this PR and did not elaborate properly (thus wrong description/title). I am referring to the way Heroku (and a couple of other providers) work with They do require disabling the certificate validation - https://devcenter.heroku.com/articles/connecting-heroku-redis |
4480ebe
to
17d6ab2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 95.57% 95.66% +0.09%
==========================================
Files 19 20 +1
Lines 610 623 +13
==========================================
+ Hits 583 596 +13
Misses 27 27 ☔ View full report in Codecov by Sentry. |
17d6ab2
to
544bca6
Compare
rediss
-schemarediss
schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use redis' native parse_url
function and override the single parameter. I would also suggest injecting the value of the parameter via an environment variable, since this is a Heroku problem.
Yeah, my initial attempt of doing so failed, as it "magically" uses different connections based on the schema provided. |
d21473a
to
98faeb0
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Certain services (like Heroku) do require disabling SSL certificate verification for their
rediss
schema:They do require disabling the certificate validation - https://devcenter.heroku.com/articles/connecting-heroku-redis
This PR is aiming to adjust the client to be able to accept
REDIS_CERT_REQS
and pass it in such cases.