Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add FreeBSD 13 for node_exporter and server #588

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebastianrakel
Copy link
Member

I added some default settings in Data to be working on FreeBSD 13

@sebastianrakel sebastianrakel changed the title Add FreeBSD 13 for node_exporter and server WIP: Add FreeBSD 13 for node_exporter and server Oct 24, 2021
@sebastianrakel sebastianrakel marked this pull request as draft October 24, 2021 14:21
@ghoneycutt
Copy link
Member

Thanks for the contribution @sebastianrakel

@smortex Thought this might be something you would be interested in.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, not a user of this module nor prometheus so maybe I am completely off… a few things look odd though 🤷.

prometheus::server::init_style: 'none'
prometheus::version: '2.30.0'
prometheus::install_method: 'package'
prometheus::bin_dir: '/usr/bin'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On FreeBSD I would expect extra software to be installed in /usr/local/bin

prometheus::version: '2.30.0'
prometheus::install_method: 'package'
prometheus::bin_dir: '/usr/bin'
prometheus::env_file_path: '/etc/defaults'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise I would expect configuration to be under /usr/local/etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants