Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core): comment node should be cached when user-enabled comment retention #12419

Closed
wants to merge 2 commits into from

Conversation

linzhe141
Copy link
Contributor

close #12417

Copy link

github-actions bot commented Nov 17, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB (+152 B) 57.8 kB (+39 B) 51.5 kB (+70 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.3 kB 16.8 kB
createApp 55.2 kB 21.3 kB 19.5 kB
createSSRApp 59.3 kB 23.1 kB 21 kB
defineCustomElement 60.1 kB 22.9 kB 20.8 kB
overall 69.1 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Nov 17, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12419

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12419

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12419

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12419

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12419

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12419

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12419

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12419

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12419

vue

pnpm add https://pkg.pr.new/vue@12419

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12419

commit: 6c71d08

@linzhe141 linzhe141 marked this pull request as draft November 17, 2024 13:21
@linzhe141 linzhe141 closed this Nov 17, 2024
@linzhe141 linzhe141 reopened this Nov 17, 2024
@edison1105
Copy link
Member

This changes the same as https://github.com/vuejs/core/pull/10748/files

@linzhe141 linzhe141 closed this Nov 18, 2024
@linzhe141 linzhe141 reopened this Nov 18, 2024
@linzhe141 linzhe141 changed the title fix: correctly handle user-enabled comment retention in production fix(compiler-core): comment node should be cached when user-enabled comment retention Nov 18, 2024
@linzhe141 linzhe141 closed this Nov 18, 2024
@linzhe141 linzhe141 deleted the fix-prod-comment branch November 18, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants