Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: properly declare optional peer deps" #2107 #2113

Closed
wants to merge 1 commit into from

Conversation

stefpb
Copy link

@stefpb stefpb commented Jun 29, 2023

This reverts commit b08b1f0.

This commit fixes #2107

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit ee12911
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/649d8d7399c2fe0008e1fa66
😎 Deploy Preview https://deploy-preview-2113--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefpb
Copy link
Author

stefpb commented Jun 29, 2023

  • i identify this commit b08b1f0
  • fork this repo ( https://github.com/stefpb/test-utils )
  • clone the repo
  • i do a git revert b08b1f04681c703d1fd14f07272337f4e9ff2bfc
  • solve (in a way) the conflicts of pnpm-lock.yaml
  • git push
  • create PR

@cexbrayat
Copy link
Member

This reverts another change that we need to keep.
I'll open another PR, thanks for the help @stefpb

@cexbrayat cexbrayat closed this Jun 30, 2023
@cexbrayat
Copy link
Member

I opened #2114 with what I had in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with yarn berry: @vue/test-utils tried to access @vue/compiler-dom
2 participants