Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime-vapor): component emits #103

Merged
merged 26 commits into from
Feb 4, 2024
Merged

feat(runtime-vapor): component emits #103

merged 26 commits into from
Feb 4, 2024

Conversation

ubugeeei
Copy link
Member

@ubugeeei ubugeeei commented Jan 30, 2024 •
edited
Loading

close: #41

related: #4

TODO:

  • test

I've implemented component emits and tests!

スクリーンショット 2024-02-02 1 16 07

@ubugeeei ubugeeei added the enhancement New feature or request label Jan 30, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 6efe75b
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/65bf8e36d2550900087f7900
😎 Deploy Preview https://deploy-preview-103--vapor-repl.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ubugeeei ubugeeei marked this pull request as draft January 30, 2024 16:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 79.7 kB 28 kB 24.6 kB
compiler-vapor.global.prod.js 44.6 kB 15 kB 13.6 kB
runtime-dom.global.prod.js 91.1 kB 34.7 kB 31.2 kB
runtime-vapor.global.prod.js 30.4 kB (+653 B) 11.8 kB (+264 B) 10.9 kB (+254 B)
vue-vapor.global.prod.js 72.6 kB (+653 B) 25.5 kB (+250 B) 23 kB (+228 B)
vue.global.prod.js 148 kB 53.9 kB 48.1 kB

Usages

Name Size Gzip Brotli
createApp 51.4 kB 20 kB 18.3 kB
createSSRApp 54.7 kB 21.3 kB 19.5 kB
defineCustomElement 53.7 kB 20.8 kB 19 kB
vapor 30.5 kB (+657 B) 11.9 kB (+279 B) 10.9 kB (+256 B)
overall 65.1 kB 25.1 kB 22.7 kB

@netlify Netlify
Copy link

netlify bot commented Feb 1, 2024 •
edited
Loading

✅ Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 6efe75b
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/65bf8e36803a940008bcb54e
😎 Deploy Preview https://deploy-preview-103--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ubugeeei
feat(runtime-vapor): init component emits
d19625d
@ubugeeei
feat(runtime-vapor): provide component emits into setup fn
0af8ffe
@ubugeeei
test(runtime-vapor): component emits (trigger handlers)
c74236a
@ubugeeei
chore: comment out unimplemented code
e5a7712
@ubugeeei
test(runtime-vapor): component emits (trigger camelCase handler)
5eeffcc
@ubugeeei
test(runtime-vapor): component emits (trigger kebab-case handler)
c707e27
@ubugeeei
test(runtime-vapor): component emits (trigger mixed case handlers)
8ed282f
@ubugeeei
feat(runtime-vapor): trigger hyphenated events for update:xxx events
d0e1ed7
@ubugeeei
feat(runtime-vapor): call emit handler with async error handling
bd3ffe5
@ubugeeei
test(runtime-vapor): component emits (should trigger array of listeners)
d240d3d
@ubugeeei
test(runtime-vapor): component emits (should not warn if has equivale…
3852eeb 
…nt onXXX prop)
@ubugeeei
test(runtime-vapor): component emits (.once)
aaa2add
@ubugeeei
test(runtime-vapor): component emits (.once with normal listener of t…
9adfff5 
…he same name)
@ubugeeei
test(runtime-vapor): component emits (.number modifier should work wi…
51b801d 
…th v-model on component)
@ubugeeei
chore: remove dead code
f73e7e7
@ubugeeei
test(runtime-vapor): component emits (.trim modifier should work with…
31180b6 
… v-model on component)
@ubugeeei
test(runtime-vapor): component emits (.trim and .number modifiers sho…
510f2b1 
…uld work with v-model on component)
@ubugeeei
test(runtime-vapor): component emits (only trim string parameter when…
acc0d98 
… work with v-model on component)
@ubugeeei
feat(runtime-vapor): isEmitListener
0d17ba7
@ubugeeei
test(runtime-vapor): component emits (does not emit after unmount)
feb813d
@ubugeeei
chore: add comments
bc86277
@ubugeeei ubugeeei marked this pull request as ready for review February 1, 2024 16:18
@ubugeeei ubugeeei requested a review from sxzz February 1, 2024 16:18
@ubugeeei ubugeeei added runtime and removed enhancement New feature or request labels Feb 3, 2024
@sxzz sxzz merged commit cde91e4 into main Feb 4, 2024
9 checks passed
@sxzz sxzz deleted the ubugeeei/feat/component-emit branch February 4, 2024 13:18
@ubugeeei ubugeeei mentioned this pull request Feb 4, 2024
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component Emits
2 participants
@ubugeeei @sxzz