Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement inheritAttrs #153

Merged
merged 34 commits into from
Mar 18, 2024
Merged

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented Mar 17, 2024

related #4
implement inheritAttrs

  • enable options
  • runtime
  • compiler
  • nested component pass through
  • test case
    • runtime case
    • compiler case

Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 47f8b9a
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/65f869de9431380008145d80
😎 Deploy Preview https://deploy-preview-153--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 47f8b9a
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/65f869dedb65210008cfe411
😎 Deploy Preview https://deploy-preview-153--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 17, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 48.9 kB (+104 B) 16.7 kB (+39 B) 15.1 kB (+19 B)
runtime-dom.global.prod.js 94.5 kB 35.6 kB 32 kB
runtime-vapor.global.prod.js 40.3 kB (+340 B) 15 kB (+96 B) 13.8 kB (+122 B)
vue-vapor.global.prod.js 86.7 kB (+444 B) 30.3 kB (+190 B) 27.4 kB (+182 B)
vue.global.prod.js 152 kB 54.9 kB 49 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21 kB 19.2 kB
createSSRApp 58.1 kB 22.3 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.9 kB
vapor 40.6 kB (+340 B) 15.1 kB (+130 B) 13.8 kB (+134 B)
overall 68.5 kB 26.1 kB 23.6 kB

@sxzz sxzz mentioned this pull request Mar 17, 2024
28 tasks
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For component, we need to set extra attrs in createComponent API
  • For native element, use setDynamicProps instead

Also, avoid using native DOM API directly in the component file.

packages/runtime-vapor/src/component.ts Outdated Show resolved Hide resolved
@Doctor-wu Doctor-wu marked this pull request as ready for review March 18, 2024 08:06
@Doctor-wu Doctor-wu requested a review from sxzz March 18, 2024 14:00
@sxzz sxzz merged commit 38e167c into vuejs:main Mar 18, 2024
8 checks passed
@sxzz sxzz changed the title feat(vapor): implement inheritAttrs feat: implement inheritAttrs Mar 18, 2024
@ubugeeei ubugeeei mentioned this pull request Mar 18, 2024
7 tasks
@sxzz sxzz linked an issue Mar 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Fallthrough Attributes
2 participants