Remove Ed25519Signature2018 tags from implementations
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Ed25519Signature2020`.
aljones15
approved these changes
Dec 15, 2023
msporny
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the test suites uses this tag and also
Ed25519Signature2018is no longer supported.Question though is do we want to remove the implementations that have the tag
vc-apiwith optionEd25519Signature2018? I believe they are issuing VCs withEd25519Signature2018proof type.Mavennet and Danube Tech uses
Ed25519Signature2018option for their vc-api implementations.NOTE: I am able to change the options type to "Ed25519Signature2020" for Danube Tech and they are able to issue a VC with
Ed25519Signature2020proof type but for Mavennet even when I change the options type, it still issues a VC withEd25519Signature2018. The vc-api implementations forEWFandSecureKeyare also generating VCs withEd25519Signature2018. What actions should we take regarding these?Edited - For now I have added a note in
README.mdthat states thatEd25519Signature2018is no longer supported so if any of the implementers were using that previously they should now update their implementations to useEd25519Signature202064d04d7, also opened an issue here #97