Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for Required Reports Phase update #774

Open
wants to merge 64 commits into
base: development
Choose a base branch
from

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    415080a View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    1f9eed0 View commit details
    Browse the repository at this point in the history
  2. Fix bug that would allow testPlanVersion to be updated to RECOMMENDED…

    … before the associated reports were all marked as final (but the tests were 100% done in the Test Queue)
    howard-e committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d2599d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    b062bac View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Refine raise an issue behavior (#753)

    * Refine raise an issue behavior
    
    * Address feedback
    
    * Fixed squished dot icon
    
    * Address last feedback
    
    * Hide closed issues on datamgmt page
    alflennik authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    cc1ec2d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e31ecab View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Filter and sort functionality for Data Management table (#750)

    * First pass on functioning sort buttons for DataManagePage
    
    * Functioning sort
    
    * Filter functionality for DataManagement
    
    * Refactor filter buttons on DataManagement to reduce complexity
    
    * Filter buttons as separate component
    
    * DataManagement page, break sort out into dedicated hook
    
    * DataManagement page, dedicated hook for filtering
    
    * DataManagement, add constant for test plan version phases to simplify hooks code
    
    * Add relevant dynamic aria attributes to DataManagement column sort elements
    
    * Add relevant dynamic aria attributes to DataManagement filter buttons
    
    * unit tests for SortableTableHeader
    
    * unit tests for FilterButtons
    
    * unit tests for useDataManagementTableSorting hook
    
    * Add unit tests for useDataManagementTableFiltering hook
    
    * Filter buttons only show buttons that have have label, handle testPlans with multiple versions, ...
    
    useDataManagementTableFiltering don't generate label for buttons that have no associated plans
    
    * Break out overall phase derivation logic into dedicated hooks, functional filter and sort
    
    * Simplify useDerivedTestPlanOverallPhase
    
    * Additional unit tests for additional hooks and to test scenarios with multiple test plan versions for a single test plan
    
    hook rename
    
    * Different UX click interaction sequence with SortableTableHeader
    
    * Correct interpretation of alphabetical ascending/descending
    
    * Rename DataManagement/hooks.js to filterSortHooks
    
    * Move sorting and filtering enums to more specific locations based on use
    
    * Fix file locations in unit tests, DataManagement, FilterButtons, SortableTableHeader
    
    * Smaller margin between buttons, FilterButtons
    
    * First pass on functioning sort buttons for DataManagePage
    
    * Functioning sort
    
    * Filter functionality for DataManagement
    
    * Refactor filter buttons on DataManagement to reduce complexity
    
    * Filter buttons as separate component
    
    * DataManagement page, break sort out into dedicated hook
    
    * DataManagement page, dedicated hook for filtering
    
    * DataManagement, add constant for test plan version phases to simplify hooks code
    
    * Add relevant dynamic aria attributes to DataManagement column sort elements
    
    * Add relevant dynamic aria attributes to DataManagement filter buttons
    
    * unit tests for SortableTableHeader
    
    * unit tests for FilterButtons
    
    * unit tests for useDataManagementTableSorting hook
    
    * Add unit tests for useDataManagementTableFiltering hook
    
    * Filter buttons only show buttons that have have label, handle testPlans with multiple versions, ...
    
    useDataManagementTableFiltering don't generate label for buttons that have no associated plans
    
    * Break out overall phase derivation logic into dedicated hooks, functional filter and sort
    
    * Simplify useDerivedTestPlanOverallPhase
    
    * Additional unit tests for additional hooks and to test scenarios with multiple test plan versions for a single test plan
    
    hook rename
    
    * Different UX click interaction sequence with SortableTableHeader
    
    * Correct interpretation of alphabetical ascending/descending
    
    * Rename DataManagement/hooks.js to filterSortHooks
    
    * Move sorting and filtering enums to more specific locations based on use
    
    * Fix file locations in unit tests, DataManagement, FilterButtons, SortableTableHeader
    
    * Smaller margin between buttons, FilterButtons
    
    * Cleanup after rebase
    
    * Render SortableTableHeader inside <table> for test to dismiss warning
    
    * Add AriaLiveRegionProvider, Update DataManagement table to use it
    
    * Allow SortableTableHeader component to work without AriaLiveRegionProvider
    stalgiag authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3357740 View commit details
    Browse the repository at this point in the history
  2. Explicitly support 'DEPRECATED' phase for TestPlanVersion.phase (#749)

    * Start to support for sunset phase
    
    * Explicitly use 'DEPRECATED' phase for TestPlanVersion.phase
    
    * Add checks to prevent test plan versions in R&D or Deprecated from being shown in data management dropdown
    
    * Remove duplicate updateTestPlanVersion call
    
    * Reuse phase variable
    
    * Add copy for deprecated reports with DisclaimerInfo component
    
    * Exclude 'DEPRECATED' testPlanVersions on DataManagement page query
    howard-e authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    232f0d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    8c85daa View commit details
    Browse the repository at this point in the history
  2. Fix test

    howard-e committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3f64387 View commit details
    Browse the repository at this point in the history
  3. Update failing test

    howard-e committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3ed8eac View commit details
    Browse the repository at this point in the history
  4. Adjust semantic structure on Data Management Page (#752)

    * Adjust cell items for data management row to use list-related roles; update aria-labels
    
    * Address PR feedback
    
    * Remove width:max-content
    
    * Address PR feedback
    
    * Formatting
    
    * Address feedback
    howard-e authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f3823b0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    452f9bb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a3b8dbe View commit details
    Browse the repository at this point in the history
  7. Formatting

    howard-e committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    112d948 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Close #755

    howard-e committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    fffdb62 View commit details
    Browse the repository at this point in the history
  2. Close #754

    howard-e committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b3366b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66267cc View commit details
    Browse the repository at this point in the history
  4. Revise required reports conditions (#764)

    * Revise required reports approach
    
    * Update tests
    
    * Revert dev.env
    howard-e authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    15f22da View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Configuration menu
    Copy the full SHA
    0828988 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Update Version History Page (#767)

    * Apply correct sort order for Timeline for All Versions section
    
    * Update headings used on Versions page
    
    * Add aria-labelledby's for tables
    
    * Add &nbsp; for applicable spaces so the text is properly announced by NVDA
    
    * Add migration to add missing deprecatedAt dates and to also properly set the candidatePhaseReachedAt dates to more practical dates after the migrations (if candidatePhaseReachedAt < draftPhaseReachedAt, set it candidatePhaseReachedAt to draftPhaseReachedAt + 1day)
    
    * Test Plan Versions Page: Use standard testPlanVersions descending sort and show all phases being included in Version Summary
    
    * Switch issues search support for checking against hidden body content instead
    
    * Fix TestPlanReportStatusDialog using d (day of the week) and y (era)
    
    * Explicit check for older date when deprecating existing RD test plan versions during import
    
    * Update hidden message content in github issue
    
    * Update query for anon user on TestRun page
    
    * Keep overall status pill from drifting to center of cell
    
    * Fix R&D only TestPlanVersion's table not being shown
    
    * Use aria-label for heading to prevent space being announced
    howard-e authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    58920b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    04c15f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    4ca4fd2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4e78fa View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    5aa85a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    e6bd038 View commit details
    Browse the repository at this point in the history
  2. Add tests

    Paul-Clue committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    349db06 View commit details
    Browse the repository at this point in the history
  3. Add required reports dropdown

    Paul-Clue authored and howard-e committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    cbfed9b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9e8a703 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c24bb53 View commit details
    Browse the repository at this point in the history
  6. Delete commented code

    Paul-Clue committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f03e87d View commit details
    Browse the repository at this point in the history
  7. Update required report table

    Paul-Clue authored and howard-e committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    0c4b432 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f6b5e7e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1354983 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a88b8d0 View commit details
    Browse the repository at this point in the history
  11. Add tests

    Paul-Clue authored and howard-e committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    3c16ce5 View commit details
    Browse the repository at this point in the history
  12. Fix reference after rebase

    howard-e committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    666ab8a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Configuration menu
    Copy the full SHA
    bccaab0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a90d72 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Configuration menu
    Copy the full SHA
    0895466 View commit details
    Browse the repository at this point in the history
  2. Remove comment

    Paul-Clue committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    84c260f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Update Timeline for All Versions table on Test Plan Versions Page (#…

    …773)
    
    * Show all versions in 'Timeline for All Versions' table
    
    * Update timestamp migrations to use more real world change phase change times (avoid exact time being set for when one phase ends and another begins)
    
    * Update import script to have a 'delayed' time on the report being deprecated
    
    * Add td -> th for first column cell for Version Summary and Timeline related tables
    
    * Match sort order described in #719
    
    * Correct deprecation date (#780)
    
    * Compare most recent test plan version to deprecate against
    
    * Correct deprecation date without using the more recent test plan version since it's being set already
    
    ---------
    
    Co-authored-by: Erika Miguel <[email protected]>
    howard-e and evmiguel authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    87abb14 View commit details
    Browse the repository at this point in the history
  2. Deprecated phase copy (#781)

    * Update deprecated phase copy
    
    * Remove unneeded change
    
    * Fix spacing in copy
    alflennik authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1338f81 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Add hidden JSON metadata to issues created by the app (#775)

    * Implement hidden metadata comment for issues
    
    * Address PR feedback
    
    * Add test plan issues graphql field
    
    * Make issue loading more resilient
    
    * Fix error that occurs when there are multiple issues to sort
    alflennik authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    77fd305 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    373a142 View commit details
    Browse the repository at this point in the history
  2. Add comment

    Paul-Clue committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    0897edb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1556b45 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    80b51b1 View commit details
    Browse the repository at this point in the history
  2. Address edge case scenarios during the updating of TestPlanVersion ph…

    …ase with old TestPlanVersion results (#771)
    
    * Revise deprecation process when copying results from earlier version to avoid unexpected errors
    
    * Additional edge case management for updatePhaseResolver during copying of old test results
    
    * Address edge cases during phase update process when using old results
    
    * Update tests to include updatePhase process
    
    * Extend default timeout
    
    * Make db docs consistent between test and dev
    
    * Update database.md formatting
    
    ---------
    
    Co-authored-by: alflennik <[email protected]>
    howard-e and alflennik authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    fae9cab View commit details
    Browse the repository at this point in the history
  3. Fix merge conflicts

    Paul-Clue committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    af052a4 View commit details
    Browse the repository at this point in the history
  4. Fix merge conflicts

    Paul-Clue committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2644b19 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Merge branch 'main' into edit-required-reports

    # Conflicts:
    #	client/components/DataManagement/queries.js
    #	client/components/ManageTestQueue/index.jsx
    #	client/components/common/PhasePill/index.jsx
    #	client/tests/__mocks__/GraphQLMocks/DataManagementPagePopulatedMock.js
    #	client/tests/__mocks__/GraphQLMocks/TestQueuePageAdminPopulatedMock.js
    #	client/tests/__mocks__/GraphQLMocks/TestQueuePageTesterPopulatedMock.js
    #	server/graphql-schema.js
    #	server/resolvers/index.js
    howard-e committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d09a0a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Pull changes from rebase

    Paul-Clue committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    176b1a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    590b550 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    868f63b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8add712 View commit details
    Browse the repository at this point in the history
  4. Fix at selection

    Paul-Clue committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b9861bb View commit details
    Browse the repository at this point in the history
  5. Fix typo

    Paul-Clue committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    34e0664 View commit details
    Browse the repository at this point in the history
  6. Fix typo

    Paul-Clue committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    612bd4c View commit details
    Browse the repository at this point in the history
  7. Fix typo

    Paul-Clue committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4aa01b9 View commit details
    Browse the repository at this point in the history
  8. Fix typo

    Paul-Clue committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9f41859 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Implement requested changes

    Paul-Clue committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    6eeafaa View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Fix merge conflicts

    Paul-Clue committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7132a12 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Configuration menu
    Copy the full SHA
    bd402b5 View commit details
    Browse the repository at this point in the history