Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

[In Progress] Bahasa Indonesia - Web Accessibility Perspectives Videos: Explore the Impact and Benefits for Everyone #65

Closed
wants to merge 46 commits into from

Conversation

frirasyidi
Copy link

@frirasyidi frirasyidi commented Nov 20, 2023

Add Bahasa Indonesia translation for:

  • index.md
  • captions.md + cc
  • contrast.md + cc
  • controls.md + cc
  • customizable.md + cc
  • keyboard.md + cc
  • layout.md + cc
  • notifications.md + cc
  • speech.md + cc
  • understandable.md + cc
  • voice.md + cc
  • cc compilation

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for wai-perspective-videos ready!

Name Link
🔨 Latest commit df3ed72
🔍 Latest deploy log https://app.netlify.com/sites/wai-perspective-videos/deploys/65671726f855730008ee9f6c
😎 Deploy Preview https://deploy-preview-65--wai-perspective-videos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@frirasyidi
Copy link
Author

@remibetin should I add language code for links in the Learn More section as well? I noticed that this is not done in the French translation, but the preview suggest that it does not directly link to the relevant translation page.

@remibetin
Copy link
Member

remibetin commented Nov 20, 2023

@frirasyidi

@remibetin should I add language code for links in the Learn More section as well?

No. The language subtag will be automatically added when these pages are translated into Indonesian. In the meantime, "(dalam Bahasa Inggris)" is automatically added at the end of the link text to specify these resources have not been translated (yet!)

We only ask you to add the language subtag to links in "Perspectives Videos" section because they are coded differently.

@frirasyidi
Copy link
Author

@remibetin I would like to notify you that there's content differences in the transcript in _perspective-videos/voice.md, _perspective-videos/cc/en/voice.en.vtt and _perspective-videos/cc/en/voice_ad.en.vtt.

As of now, I'm adjusting the translation according to each file's content. Let me know if there's any adjustment that I need to make.

@frirasyidi frirasyidi changed the title [In-progress] Bahasa Indonesia - Web Accessibility Perspectives Videos: Explore the Impact and Benefits for Everyone [Ready to Review] Bahasa Indonesia - Web Accessibility Perspectives Videos: Explore the Impact and Benefits for Everyone Nov 21, 2023
@frirasyidi
Copy link
Author

frirasyidi commented Nov 22, 2023

@remibetin I noticed that the link to caption caption file in the main page is redirecting to English in Bahasa Indonesia page. And it links to some .../compilations.srt instead of the .../cc/compilation.id.vtt file.

I don't think I missed any step from the Translation Notes. Will this be automatically generated from the .../cc/compilation.id.vtt or something needs to be done from my side?

Another thing is that the video does not automatically use Bahasa Indonesia as its default caption. I take a look at the required steps to do so (outlined here) but the implementation is different on the file as bellow:

In guide:

{% include video-player.html
   yt-id="20SHvU2PKsM"
   path="/path/to/vtt/files/"
   captions="VTT_FILE_NAME.vtt|en|default"
   subtitles="VTT_FILE_NAME.es.vtt|es"
%}

In file:

{% include video-player-data.html
    yt-id="Hui87z2Vx8o"
    yt-id-ad="a9kNUv6N8Rk"
    path="/perspective-videos/cc/"
    lang-folder=true
    vtt-data-location="wai-perspective-videos"
    vtt-name="contrast"
%}

I noticed that the French translation did not attempt any changes to make French its default. Could you please provide advise on how to proceed?

@remibetin
Copy link
Member

@frirasyidi

I noticed that the link to caption caption file in the main page is redirecting to English in Bahasa Indonesia page. And it links to some .../compilations.srt instead of the .../cc/compilation.id.vtt file.

I need to check something; I will get back to you on this. For now, keep the existing link to .../compilations.srt

Another thing is that the video does not automatically use Bahasa Indonesia as its default caption.

Indeed, I opened an issue some weeks ago (w3c/wai-video-standards-and-benefits#118) and am in the process of fixing this.

I noticed that the French translation did not attempt any changes to make French its default.

We are currently simplifying the way VTT files are managed: I will update the documentation next week.

Do not mind about the video player include for now: you can focus on the VTT files and the page content for now, and I will directly commit the necessary changes in your PR when ready (likely next week).

@frirasyidi frirasyidi changed the title [Ready to Review] Bahasa Indonesia - Web Accessibility Perspectives Videos: Explore the Impact and Benefits for Everyone [In Progress] Bahasa Indonesia - Web Accessibility Perspectives Videos: Explore the Impact and Benefits for Everyone Dec 1, 2023
@frirasyidi
Copy link
Author

@remibetin per our communication via email, this document status is changed back to [In Progress], waiting for check from your side before ready to review.

@remibetin
Copy link
Member

This PR has been split into two:
– Resource update: #67
– VTT update: w3c/wai-website-data#115

@remibetin remibetin closed this Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants