Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white-space group, features #1698

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Aug 28, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 28, 2024
@@ -0,0 +1,6 @@
name: text-wrap-mode
description: The `text-wrap-mode` CSS property sets whether lines may wrap. It is a longhand for both `white-space` and `text-wrap`. Options are `wrap` and `nowrap`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The `text-wrap-mode` CSS property sets whether lines may wrap. It is a longhand for both `white-space` and `text-wrap`. Options are `wrap` and `nowrap`.
description: The `text-wrap-mode` CSS property sets whether lines may wrap with the values `wrap` and `nowrap`. It is a longhand property for both `white-space` and `text-wrap`.

@@ -0,0 +1,6 @@
name: text-wrap-mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but apparently this is not likely to be a durable name? Part of me wants to call this something like "Untitled text wrap property." 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that, but opted to use the name because it's already implemented in a couple browsers with that name, and I'm not finding conversations about actually bikeshedding the name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer an open question. It was resolved by the group to stick with text-wrap-mode.

features/white-space-collapse.yml Outdated Show resolved Hide resolved
groups/white-space.yml Outdated Show resolved Hide resolved
groups/white-space.yml Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from ddbeck August 29, 2024 16:26
description: The `white-space-collapse` CSS property sets whether new line characters are shown as line breaks, and whether multiple consecutive spaces are all displayed or combined.
spec: https://drafts.csswg.org/css-text-4/#white-space-collapsing
group: white-space
compat_features:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several values defined in the spec that are not listed here (and don't have BCD keys) - such as preserve-spaces and discard. What's the proper way to handle that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything that's implemented in at least one browser ought to have a key in BCD, so we're definitely missing at least preserve-spaces, perhaps more. I've filed mdn/browser-compat-data#24363 about this case specifically.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For largely historical reasons, BCD didn't record CSS property values comprehensively, only values added "later" (subjective, sometimes). I brought this up in a BCD meeting recently and was told to file issues about missing values.

@ddbeck ddbeck merged commit 8e3e27e into web-platform-dx:main Sep 6, 2024
3 checks passed
@jamesnw jamesnw deleted the white-space branch September 9, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants