Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DIP] Add support for isolate-and-credentialless #48252

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 18, 2024

This CL ensures that no-CORS cross-origin subresources requests from
documents with Document-Isolation-Policy: isolate-and-credentialless are
stripped of credentials. Since CORP checks already support
Document-Isolation-Policy: isolate-and-credentialless, this is enough to
enable cross-origin isolation in documents with
Document-Isolation-Policy: isolate-and-credentialless.

Bug: 349792240
Change-Id: I21bacba16a62dc8dd7c101450819466208815f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5867191
Commit-Queue: Camille Lamy <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1365616}

This CL ensures that no-CORS cross-origin subresources requests from
documents with Document-Isolation-Policy: isolate-and-credentialless are
stripped of credentials. Since CORP checks already support
Document-Isolation-Policy: isolate-and-credentialless, this is enough to
enable cross-origin isolation in documents with
Document-Isolation-Policy: isolate-and-credentialless.

Bug: 349792240
Change-Id: I21bacba16a62dc8dd7c101450819466208815f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5867191
Commit-Queue: Camille Lamy <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1365616}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 671f9e8 into master Oct 8, 2024
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5867191 branch October 8, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants