-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign poll component #2707
Redesign poll component #2707
Conversation
c8a012c
to
58a1f7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing this I noticed that old polls give you the opiton to vote, even though voting is impossible because the polls are no longer valid. This happens with the old component too, so I guess it's not really your responsibility, but it would be super nice if you fixed it. Should be as simple as checking if poll.validUntil
is before now, and f.ex. showing results if this is the case.
Nicely spotted! :o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a step in the right direction! 😍 However, I do have some comments
Also, I don't get this. Please make it perfect from the beginning. I thought we agreed that we'd merge these into master, and get one component at a time into prod? At least that's more agile™️ |
9470381
to
dfb91e2
Compare
No:) The final conclusion was to use the plan stated in the pr above |
1337042
to
74a4da0
Compare
6fa9a34
to
ae49e0e
Compare
cbb6e1c
to
4973b34
Compare
Looks way cleaner now, thanks for all the input @ivarnakken! 😍 Merging this in two days if no additional comments are made, We'll be able to make final design-adjustments in the |
4973b34
to
f1e946d
Compare
If you look really close at the video you see the order of options change whenever the poll is closed / opened (yikes). Removed this "feature" with a |
f1e946d
to
cf1b441
Compare
Closing this due to being stale for 2 years |
New poll waddup
poll.mp4
Tooltip is a bit hidden, but will be a one-liner with the new forntpage:)