Add warning to pin to frontpage #4999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
emillub
force-pushed
the
add-warning-to-pin-to-front-page
branch
from
498eed2
to
15af74b
Compare
|
LGMT! |
norbye
approved these changes
Sep 25, 2024
ivarnakken
approved these changes
Sep 25, 2024
| @@ -179,6 +180,15 @@ const ArticleEditor = () => { | |||
| type="checkbox" | |||
| component={CheckBox.Field} | |||
| /> | |||
| {values.pinned && ( | |||
| <Card style={{ marginTop: 0 }} severity="warning"> | |||
There was a problem hiding this comment.
Ideally we don't want any inline styling
| {values.pinned && ( | ||
| <Card style={{ marginTop: 0 }} severity="warning"> | ||
| <span> | ||
| OBS! Du må ha godkjenning fra ledelsen for å feste til |
There was a problem hiding this comment.
Could the "obs" be in a Card.Header so that it matches other cards better?😁
Comment on lines
70
to
73
| <Card style={{ marginTop: 0 }} severity="warning"> | ||
| <span> | ||
| OBS! Du må ha godkjenning fra ledelsen for å feste til forsiden. | ||
| </span> |
There was a problem hiding this comment.
Juni and I concluded that the syling wasn't necessary so we removed it:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warning under "fest til forsiden" to make i clear you need permission to pin.
Applies to article- and event-editing.
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves: ABA-1077