Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adminComment/note field from companies #5001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juniwbjerde
Copy link
Member

@juniwbjerde juniwbjerde commented Sep 25, 2024

Description

Removed the field adminComment from company. It was only used in the bdb table, and just took up unnecessary space and was never really used for anything...

Testing

  • [ x] I have thoroughly tested my changes.

Corresponding backend changes: webkom/lego#3643

Resolves ABA-1052

Copy link

linear bot commented Sep 25, 2024

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 9:08pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Sep 25, 2024
@ivarnakken
Copy link
Member

See comment on backend PR. I thought we only wanted to remove it from the table? I know it's somewhat kinda used sometimes😆😅

@juniwbjerde
Copy link
Member Author

@ivarnakken I've answered you in the backed PR as well, but what does "somewhat kinda somethimes" mean? Falk got the impression that Bedkom never really use it as far as i understood

@ivarnakken
Copy link
Member

@ivarnakken I've answered you in the backed PR as well, but what does "somewhat kinda somethimes" mean? Falk got the impression that Bedkom never really use it as far as i understood

I've seen it be used, but it's never been used very thoroughly. I thought we discussed that we wanted to improve the comments and make something similar to itDAGENE's system. I agree that it should be removed from the table though. Not sure if we have to remove it as a feature all together, because ideally we would want them to use it more. I guess our job is to make it more intuitive and useful. Perhaps Falk or Isak can show itDAGENE's admin page

@ivarnakken
Copy link
Member

Oh I read your comment on lego now! I totally forgot we had "normal" comments as well, so in that case I'm totally in for completely yeeting it😁sorry hehe

dataIndex: 'comment',
// Using an empty column for filtering
title: '',
dataIndex: 'Filter',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dataIndex: 'Filter',
dataIndex: 'active',

dataIndex: 'comment',
// Using an empty column for filtering
title: '',
dataIndex: 'Filter',
centered: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed now?

@ivarnakken ivarnakken added the chore Pull requests that does something "boring", yet important, e.g. cleaning up code label Sep 27, 2024
Copy link
Contributor

@itsisak itsisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree with this change. As mentioned by Ivar, the itDAGENE admin page only uses a comment field for this and it works great.

Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests that does something "boring", yet important, e.g. cleaning up code review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants