Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show one semester at a time on BDB #5017

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

falbru
Copy link
Contributor

@falbru falbru commented Oct 2, 2024

Description

Related backend PR

  • Update to refactored backend bdb endpoint
  • Only show one semester at a time
  • (Coming soon: student contacts for a company should be distinct for each semester. Waiting for other PRs first)

TODO:

  • The viewed semester can be changed by the semesterId query in the URL. We should probably add a dropdown for this at some point

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
    • BDB looks trash on mobile
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Before After

Testing

  • I have thoroughly tested my changes.

Changing semester statues still work
The detailed bdb route still works


Resolves ABA-1049, ABA-1051

@falbru falbru requested a review from a team October 2, 2024 18:07
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 6:38pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 2, 2024
@falbru falbru changed the title Refactor bdb endpoint Only show one semster at a time on BDB Oct 4, 2024
@falbru falbru changed the title Only show one semster at a time on BDB Only show one semester at a time on BDB Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant