Fix minor bugs

lego/apps/lending/managers.py

@@ -3,7 +3,7 @@
 
 class LendingInstanceManager(BasisModelManager):
     def create(self, *args, **kwargs):
-        from lego.apps.lending.notifications import LendingInstanceNotification
+        from lego.apps.lending.notifications import LendingInstanceCreateNotification
         from lego.apps.users.models import Membership, User
 
         lending_instance = super().create(*args, **kwargs)
@@ -19,26 +19,13 @@ def create(self, *args, **kwargs):
             ).values_list("user", flat=True)
         for user_id in users_to_be_notified:
             user = User.objects.get(pk=user_id)
-            notification = LendingInstanceNotification(
+            notification = LendingInstanceCreateNotification(
                 lending_instance=lending_instance,
                 user=user,
             )
             notification.notify()
 
         return lending_instance
 
-    # TODO: We probably need another template for accepting instances
-    def update(self, *args, **kwargs):
-        from lego.apps.lending.notifications import LendingInstanceNotification
-
-        lending_instance = super().update(*args, **kwargs)
-        notification = LendingInstanceNotification(
-            lending_instance=lending_instance,
-            user=lending_instance.created_by,
-        )
-        notification.notify()
-
-        return lending_instance
-
     def get_queryset(self):
         return super().get_queryset().select_related("created_by")

lego/apps/lending/migrations/0001_initial.py

@@ -1,4 +1,4 @@
-# Generated by Django 4.0.10 on 2024-04-16 18:32
+# Generated by Django 4.0.10 on 2024-05-24 11:03
 
 import datetime
 
@@ -16,7 +16,7 @@ class Migration(migrations.Migration):
     initial = True
 
     dependencies = [
-        ("users", "0041_user_linkedin_id_alter_user_github_username"),
+        ("users", "0043_alter_abakusgroup_type"),
         ("files", "0005_file_save_for_use"),
         migrations.swappable_dependency(settings.AUTH_USER_MODEL),
     ]
@@ -186,7 +186,18 @@ class Migration(migrations.Migration):
                 ("require_auth", models.BooleanField(default=True)),
                 ("start_date", models.DateTimeField(null=True)),
                 ("end_date", models.DateTimeField(null=True)),
-                ("pending", models.BooleanField(default=True)),
+                (
+                    "status",
+                    models.CharField(
+                        choices=[
+                            ("PENDING", "Pending"),
+                            ("ACCEPTED", "Accepted"),
+                            ("REJECTED", "Rejected"),
+                        ],
+                        default="PENDING",
+                        max_length=8,
+                    ),
+                ),
                 ("message", models.TextField(blank=True)),
                 (
                     "can_edit_groups",

lego/apps/lending/notifications.py

@@ -4,7 +4,7 @@
 from lego.apps.users.models import User
 
 
-class LendingInstanceNotification(Notification):
+class LendingInstanceCreateNotification(Notification):
     def __init__(self, lending_instance: LendingInstance, user: User):
         self.lending_instance = lending_instance
         self.lender = lending_instance.user