Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "too late" as an event presence status #3564

Merged
merged 3 commits into from
Mar 15, 2024

Commits on Mar 14, 2024

  1. Introduce "too late" as an event presence status

    Similar to the "not present" status, the user will automatically recieve
    a penalty. I figured all previous penalties can be removed since only
    the newest one should matter.
    
    I would like some input as to how this will affect other penalties,
    e.g. given due to late payments (or other things?), as they will also
    be removed if the presence is changed to something worthy of a penalty.
    Should we consider to introduce "penalty types" stored on the record,
    e.g. "presence", "payment", "other"?
    
    Also, this resolves a bug, as it is currently not possible to auto delete
    previous penalties related to the event due to the `.delete()` not being
    at the end the atomic block. Not sure why it had to be atomic in the
    first place.
    ivarnakken committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9ed1443 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Include penalty types to the model

    Used to distinguish and delete the correct penalties, as penalties from
    the same type (and event) should in theory never stack.
    ivarnakken committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3a209a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c9acb5f View commit details
    Browse the repository at this point in the history