-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Typed Source #17
Open
LuanHimmlisch
wants to merge
15
commits into
master
Choose a base branch
from
feature/TypedSource
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please update the readme with the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to refactor the code relating to the state of the Front actions taken by the user, also known as the
source
type. Previously, this source was managed as a simplestring
that prevents Intellisense from working, and allows human error.This PR does the following to fix the mentioned errors:
WeblaborMx\Front\Source
class, that is meant to be used as anEnum
compatible with PHP 7.1.isForm()
,isServerSide()
andisClientSide()
.session()
out of theSourceable
trait, in order to reuse it inside theInput
class.Source
classStringable
so it can be cast tostring
and used as it was.$source
variable as@deprecated
to prevent the usage.With this PR, the value of the source is always known, through enumeration, validation and IDE autocompletion.