Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Add Dockerfile and entrypoint files #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lazarus404
Copy link

@Lazarus404 Lazarus404 commented Jul 7, 2020

This PR needs an updated kite-common to work.

To use, build the image passing in the args for the test directory name and config file name:

docker build -t kite --build-arg TEST_PATH_DIR="KITE-AppRTC-Test" --build-arg CONFIG_FILE_NAME="js.iceconnection.apprtc.config.json" .

Then launch the image like this:

docker run -it kite:latest

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Lazarus404
Copy link
Author

Lazarus404 commented Jul 7, 2020 via email

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Lazarus404
Copy link
Author

Lazarus404 commented Jul 7, 2020 via email

2 similar comments
@Lazarus404
Copy link
Author

Lazarus404 commented Jul 8, 2020 via email

@Lazarus404
Copy link
Author

@googlebot I fixed it.

@Lazarus404
Copy link
Author

Dagnabbit @googlebot!

@Lazarus404
Copy link
Author

Lazarus404 commented Jul 8, 2020 via email

@namvuCosmo
Copy link
Contributor

I checked out your repository and used the command you gave above, got some error though. I'm using docker on Windows and not Linux, should that be a problem?
image

@Lazarus404
Copy link
Author

Lazarus404 commented Jul 20, 2020

Yes, that will be the problem. You can create Linux Docker images on Linux and Macs, but on Windows, you can only create Windows images. It’s due to containers using the underlying host engine.

@namvuCosmo
Copy link
Contributor

hmm, I thought it was only that you cannot run Linux docker on Windows. Anyway, I tried on Linux, the grid didn't seem to get launched. I updated kite-common with your PR as well.

Am I missing something?

image

out.log

@Lazarus404
Copy link
Author

The grid failed for some reason. Now that the library has been updated, I will create a fresh install, today, and see if I can reproduce.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Lazarus404
Copy link
Author

This PR has been updated. Tests should now run.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants