feat(human-readable): parse EIP712 human-readable type signatures #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e917c51 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Features
Chore
Documentation
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
Size Change: +1.5 kB (+3%) Total Size: 49.9 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
========================================
Coverage 99.90% 99.91%
========================================
Files 21 22 +1
Lines 2055 2281 +226
Branches 325 362 +37
========================================
+ Hits 2053 2279 +226
Misses 2 2
☔ View full report in Codecov by Sentry. |
3 tasks
|
@tmm with the restructure do you want me to re-open this PR or do you think that this doesn't make sense in having for abitype? |
tmm
force-pushed
the
main
branch
4 times, most recently
from
6b36159
to
c706a9a
Compare
tmm
force-pushed
the
main
branch
3 times, most recently
from
ffcd744
to
62b32d7
Compare
|
@Raiden1411 this PR is great work and maybe we'll add it in someday (EIP-712 isn't a burning use-case it seems right now). Going to close out for the time-being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for EIP712 typed data signatures.
Essentially the typed data human readable signature is represented as a struct signature. This however differs from Abi structs, since this will follow the specifications introduced in EIP712.
The new
parseTypedDatafunction parses in two contexts. Either if you want to create and resolve the typed data or simply want to create it (the latter is the default behavior).This also introduces a couple of new types for consumers to use.
ParseTypedData,ResolveTypedData,ResolvedTypedDataandResolvedTypedDataToPrimativeTypes.Examples were created to demonstrate this new pattern and the documentation also reflects these changes.
Additional Information
Your ENS/address:
PR-Codex overview
This PR adds human-readable EIP-712 parsing utilities and resolves typed data into corresponding Solidity primitive types.
Detailed summary
parseTypedDatafunction to parse human-readable typed data into EIP-712 typed data.MissingNamedParametererror class for missing named parameters in EIP-712 typed data.