Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(public): add createAccessList #2855

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Rubilmax
Copy link

@Rubilmax Rubilmax commented Oct 14, 2024

This PR is a draft for the eth_createAccessList support requested here: #1060

It is missing:

  • tests
  • docs

PR-Codex overview

This PR updates the viem package to version 2.21.25, introduces a new method eth_createAccessList, and enhances error handling for creating access lists in Ethereum transactions.

Detailed summary

  • Updated viem package version from 2.21.24 to 2.21.25.
  • Added eth_createAccessList method with detailed documentation.
  • Introduced CreateAccessListParameters and CreateAccessListReturnType.
  • Enhanced error handling in getCreateAccessListError function.
  • Updated publicActions to include createAccessList.
  • Added new utility types and imports for access list creation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: e820a54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 14, 2024

@Rubilmax is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom
Copy link
Member

jxom commented Oct 14, 2024

This looks great so far! Were you planning on adding those tests & docs? :)

@Rubilmax
Copy link
Author

This looks great so far! Were you planning on adding those tests & docs? :)

Thanks! Sure, I just don't want to rush it because so many times in OS you receive comments too late in the process and it costs more time than required

I'll be working on these asap!

@jxom
Copy link
Member

jxom commented Oct 15, 2024

legend

@jxom
Copy link
Member

jxom commented Oct 28, 2024

@Rubilmax – were you planning on doing this?

@Rubilmax
Copy link
Author

@Rubilmax – were you planning on doing this?

I was and still am, but I didn't have the time so far... If the feature is important feel free to do it and close this PR, otherwise I'll work on this as soon as I can

@jxom
Copy link
Member

jxom commented Oct 28, 2024

All good! I can convert to draft for now :)

@jxom jxom marked this pull request as draft October 28, 2024 21:47
@jxom jxom force-pushed the main branch 10 times, most recently from 5c14479 to 373eafa Compare November 20, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants