Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability. maybe.. #1326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zhangenming
Copy link

@zhangenming zhangenming commented Nov 19, 2024

At first I was a little confused when I read the words and it felt strange
I'm trying to make it a little more readable in the hope that it helps

before:
image

after:
image


Preview | Diff

@annevk
Copy link
Member

annevk commented Nov 19, 2024

While I appreciate the suggestion, this makes it less consistent with the language we use elsewhere.

An alternative that could maybe work is to rename the variables to nodeA and nodeB to distinguish them more from the leading "A". WDYT?

@zhangenming
Copy link
Author

image

@zhangenming
Copy link
Author

how about use 'the' word
image

@zhangenming
Copy link
Author

zhangenming commented Nov 19, 2024

this makes it less consistent with the language we use elsewhere.

Either solution seems to require global modification

@annevk
Copy link
Member

annevk commented Nov 19, 2024

"The" has the same issue as removing "A". I'm not sure what you mean with global modification for my solution? I don't think there's that many variables named "A"? Or perhaps I misunderstood the problem?

@zhangenming
Copy link
Author

zhangenming commented Nov 19, 2024

<var>A</var> search result : 44

@zhangenming
Copy link
Author

a node a // strange
a node nodeA // redundancy
the node a // better
node a // best

Whichever option is chosen
Will causethis makes it less consistent with the language we use elsewhere.
So i think the whole thing needs to be revised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants