Reorder promise resolutions for navigation API #10658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API method tracker finished promise vs. the navigation transition finished promise ordering did not match the tests and Chromium implementation. There's no real argument for one order vs. the other, so update the spec to match. Closes #10646.
rwlbuis
added a commit
to rwlbuis/WebKit
that referenced
this pull request
Sep 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=280398 Reviewed by NOBODY (OOPS!). Reorder order of resolving transition and finished promises, the tests already expect this order and the spec was adjusted recently: whatwg/html#10658 * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent):
annevk
approved these changes
Sep 30, 2024
webkit-commit-queue
pushed a commit
to rwlbuis/WebKit
that referenced
this pull request
Sep 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=280398 Reviewed by Anne van Kesteren. Reorder order of resolving transition and finished promises, the tests already expect this order and the spec was adjusted recently: whatwg/html#10658 * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): Canonical link: https://commits.webkit.org/284445@main
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Sep 30, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Sep 30, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts.
awesomekling
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Sep 30, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts.
ebanner
pushed a commit
to ebanner/ladybird
that referenced
this pull request
Oct 4, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts.
ebanner
pushed a commit
to ebanner/ladybird
that referenced
this pull request
Oct 15, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts.
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 9, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts. (cherry picked from commit ec15f8fa626e5b0faf5b3e420080e944ab31ff11)
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 10, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts. (cherry picked from commit ec15f8fa626e5b0faf5b3e420080e944ab31ff11)
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 10, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts. (cherry picked from commit ec15f8fa626e5b0faf5b3e420080e944ab31ff11)
nico
pushed a commit
to SerenityOS/serenity
that referenced
this pull request
Nov 10, 2024
Applies changes in whatwg/html#10658 and also whichever previous change split the step for firing the navigateerror into two parts. (cherry picked from commit ec15f8fa626e5b0faf5b3e420080e944ab31ff11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API method tracker finished promise vs. the navigation transition finished promise ordering did not match the tests and Chromium implementation. There's no real argument for one order vs. the other, so update the spec to match.
Closes #10646.
(See WHATWG Working Mode: Changes for more details.)
/nav-history-apis.html ( diff )