Spec :user-invalid & :user-valid #9047

nt1m · 2023-03-17T18:17:04Z

At least two implementers are interested (and none opposed):
- WebKit (Implemented)
- Gecko (Implemented)
- Chromium (Spec :user-invalid & :user-valid #9047 (review))
Tests are written and can be reviewed and commented upon at:
- Basic interaction tests: WebKit export of https://bugs.webkit.org/show_bug.cgi?id=254571 web-platform-tests/wpt#39293
- Form submission & reset tests: WebKit export of https://bugs.webkit.org/show_bug.cgi?id=257988 web-platform-tests/wpt#41378
Implementation bugs are filed:
- Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1156069
- Gecko: Already implemented
- WebKit: Already implemented
- Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): n/a
- Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): n/a
MDN issue is filed: none needed, docs already exist.

(See WHATWG Working Mode: Changes for more details.)

/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/semantics-other.html ( diff )

annevk

Thanks for tackling this! Left a number of inline comments.

This would benefit from review by someone in @whatwg/css, @emilio, and @mfreed7.

source

mfreed7

Generally this looks reasonable - just some small comments.

mfreed7 · 2023-03-31T20:42:00Z

source

@@ -58845,8 +58849,8 @@ fur

  <p>The algorithm to <dfn id="constructing-the-form-data-set" export data-lt="constructing the
  entry list" data-x="constructing the entry list">construct the entry list</dfn> given a
-  <var>form</var>, an optional <var>submitter</var>, and an optional <var>encoding</var>, is as
-  follows. If not specified otherwise, <var>submitter</var> is null.</p>
+  <var>form</var>, an optional <var>submitter</var>, an optional <var>resetUserInteracted</var>


Does resetUserInteracted need a default?

Actually, more important question: is resetUserInteracted needed? It doesn't appear to be set anywhere.

Oops, I forgot to use it in the form submission algorithm

source

mfreed7 · 2023-03-31T20:45:55Z

source

+      defined <span>activation behavior</span>, and the user has changed the element's <span
+      data-x="concept-fe-value">value</span> or its list of <span
+      data-x="concept-input-type-file-selected">selected files</span> while the control was focused
+      without committing that change (such that it is different to what it was when the control was


Is "committing that change" well defined? E.g. for an <input type=file> I'm not sure where the commit happens - clicking ok on the file picker? Moving focus elsewhere?

I realize that this language was here before - just wondering if it needs clarification.

mfreed7 · 2023-03-31T23:02:56Z

Side question: is there a plan to expand the WPT test suite for these pseudos? As I mentioned in web-platform-tests/interop#304, the current testing is quite light.

nt1m · 2023-03-31T23:11:10Z

Side question: is there a plan to expand the WPT test suite for these pseudos? As I mentioned in web-platform-tests/interop#304, the current testing is quite light.

There's an initial set of tests getting landed in web-platform-tests/wpt#39293

I'm hoping to write more whenever I have time.

I'm off next week, but here's what planning to do:

FACE tests
<button> / <select> tests
Form submission tests (resets the user-interacted state), also test that FormData() does not reset.
Potentially port some of these tests: https://searchfox.org/mozilla-central/search?q=moz-ui-%28in%29%3Fvalid&path=test&case=false&regexp=true

mfreed7 · 2023-03-31T23:18:30Z

There's an initial set of tests getting landed in web-platform-tests/wpt#39293

I'm hoping to write more whenever I have time.

I'm off next week, but here's what planning to do:

Awesome, thank you!

mfreed7 · 2023-05-25T15:07:37Z

I'm hoping to write more whenever I have time.

Hello, just checking in on this issue! Any progress on spec or WPTs?

nt1m · 2023-05-25T15:45:22Z

I'm hoping to write more whenever I have time.

Hello, just checking in on this issue! Any progress on spec or WPTs?

No progress on the spec unfortunately (hoping to get to it soon), but regarding WPT, web-platform-tests/wpt#39293 has since been merged, which should have basic WPT regarding behavior (not just parsing).

mfreed7 · 2023-05-30T21:53:36Z

I'm hoping to write more whenever I have time.

Hello, just checking in on this issue! Any progress on spec or WPTs?

No progress on the spec unfortunately (hoping to get to it soon), but regarding WPT, web-platform-tests/wpt#39293 has since been merged, which should have basic WPT regarding behavior (not just parsing).

Oh great, thanks for landing that. Feel free to cc me on the spec PR, but we'll get started on at least that basic behavior.

source

nt1m · 2023-06-13T00:58:08Z

We received some valuable feedback on the :user-invalid behavior on form submission, I'll be reworking a bit the form submission model.

mfreed7 · 2023-08-01T15:32:05Z

We received some valuable feedback on the :user-invalid behavior on form submission, I'll be reworking a bit the form submission model.

Checking in here. While the WPTs look reasonable for the normal use case behavior, the lack of a landed spec makes me a bit nervous about including this in Interop 2023. I previously closed web-platform-tests/interop#304, but I'm wondering if I should re-open it? And we can punt this item until Interop 2024, perhaps?

nt1m · 2023-08-07T19:34:04Z

I just updated the spec PR to address the developer feedback received.

nt1m · 2023-08-08T04:52:01Z

I added some form submission & reset WPTs at: web-platform-tests/wpt#41378

nt1m · 2023-08-08T04:52:36Z

@mfreed7 @josepharhar @annevk @emilio Can you please take a look at this PR?

nt1m · 2023-08-08T05:04:40Z

This PR defines FACE or buttons to be equivalent to :valid / :invalid (although that isn't really what WebKit does atm), but I'm open to feedback for what folks want to do for non-textfield form controls in general.

https://bugs.webkit.org/show_bug.cgi?id=257988 rdar://110677832 Reviewed by Aditya Keerthi. Form submission should trigger user-validation styles, to do this, we set the user-interacted flag to true on form submission (but only initiated from user input). Form reset should reset form control user-interacted flags. This matches the WIP spec PR at: whatwg/html#9047 * LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-invalid.html: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-valid.html: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/selectors/user-invalid-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/selectors/user-valid-expected.txt: * Source/WebCore/html/FormAssociatedCustomElement.cpp: (WebCore::FormAssociatedCustomElement::reset): * Source/WebCore/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitIfPossible): * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset): * Source/WebCore/html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::reset): * Source/WebCore/html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset): * Source/WebCore/html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::reset): Canonical link: https://commits.webkit.org/266702@main

mfreed7 · 2023-08-09T16:50:46Z

This PR defines FACE or buttons to be equivalent to :valid / :invalid (although that isn't really what WebKit does atm), but I'm open to feedback for what folks want to do for non-textfield form controls in general.

I see the FACE point, but aren't all buttons barred from constraint validation?

mfreed7

I think this looks pretty reasonable, modulo a few questions.

source

mfreed7

You can add Chromium to the commit message - we're supportive.

source

Fixes whatwg#8452

nt1m · 2023-08-21T17:28:22Z

I've addressed all the feedback here, can you please take another look?

domenic

I pushed a small fixup PR. Please take a look, and in particular at the new reset algorithm for the select element. The previous one was too confusing so I had to clean it up to make sense of what the new step was actually trying to do.

I have one question inline abut something I don't understand.

source

annevk · 2023-08-24T12:06:44Z

I pushed a couple nits. Looks good modulo the category comment above and a follow-up issue for custom elements. I guess for custom elements we want some kind of ElementInternals state?

nt1m · 2023-08-26T08:41:21Z

I filed #9639 for FACE

It's addressed.

nt1m force-pushed the user-valid-invalid branch from 4496680 to d67b1bf Compare March 17, 2023 18:19

nt1m requested a review from annevk March 17, 2023 18:19

nt1m mentioned this pull request Mar 17, 2023

Tests (and spec) for :user-valid and :user-invalid are... light web-platform-tests/interop#304

Closed

annevk reviewed Mar 22, 2023

View reviewed changes

source Outdated Show resolved Hide resolved

source Outdated Show resolved Hide resolved

source Outdated Show resolved Hide resolved

source Outdated Show resolved Hide resolved

foolip mentioned this pull request Mar 30, 2023

Summary of outstanding test change review web-platform-tests/interop#315

Closed

nt1m force-pushed the user-valid-invalid branch 3 times, most recently from a9180b9 to 13f6b4c Compare March 31, 2023 20:00

mfreed7 reviewed Mar 31, 2023

View reviewed changes

jacobrask reviewed Jun 1, 2023

View reviewed changes

source Outdated Show resolved Hide resolved

nt1m force-pushed the user-valid-invalid branch from 13f6b4c to d3a7216 Compare August 7, 2023 19:33

nt1m force-pushed the user-valid-invalid branch from d3a7216 to cc8790d Compare August 7, 2023 20:04

nt1m mentioned this pull request Aug 8, 2023

Fix :user-invalid/:user-valid interactions with form reset & submission WebKit/WebKit#16465

Merged

nt1m force-pushed the user-valid-invalid branch 2 times, most recently from 030429b to 864288a Compare August 8, 2023 05:29

mfreed7 reviewed Aug 9, 2023

View reviewed changes

source Show resolved Hide resolved

source Outdated Show resolved Hide resolved

sysrqb mentioned this pull request Aug 9, 2023

Plumb SecurityOriginData from Network requests WebKit/WebKit#16509

Merged

mfreed7 approved these changes Aug 11, 2023

View reviewed changes

source Outdated Show resolved Hide resolved

domenic previously requested changes Aug 14, 2023

View reviewed changes

nt1m force-pushed the user-valid-invalid branch from 864288a to aaf0465 Compare August 18, 2023 17:04

Spec :user-invalid & :user-valid

58f82bf

Fixes whatwg#8452

nt1m force-pushed the user-valid-invalid branch from aaf0465 to 58f82bf Compare August 18, 2023 17:15

Minor fixes plus rewrite select's reset algorithm

cbbe99d

domenic reviewed Aug 24, 2023

View reviewed changes

source Show resolved Hide resolved

nt1m and others added 2 commits August 23, 2023 22:55

Remove :user-invalid & :user-valid definitions for buttons

9a75464

editorial nits

7cec4aa

Collapse :user-valid/invalid condition list

b5e0010

nt1m mentioned this pull request Aug 26, 2023

Define :user-invalid / :user-valid for form-associated custom elements #9639

Open

correct markup

0bd00c5

annevk approved these changes Aug 28, 2023

View reviewed changes

annevk merged commit 834da11 into whatwg:main Aug 28, 2023
1 check passed

nt1m deleted the user-valid-invalid branch August 28, 2023 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spec :user-invalid & :user-valid #9047

Spec :user-invalid & :user-valid #9047

nt1m commented Mar 17, 2023 •

edited by pr-preview bot

Loading

annevk left a comment

mfreed7 left a comment

mfreed7 Mar 31, 2023

nt1m Mar 31, 2023

mfreed7 Mar 31, 2023

mfreed7 commented Mar 31, 2023

nt1m commented Mar 31, 2023 •

edited

Loading

mfreed7 commented Mar 31, 2023

mfreed7 commented May 25, 2023

nt1m commented May 25, 2023

mfreed7 commented May 30, 2023

nt1m commented Jun 13, 2023

mfreed7 commented Aug 1, 2023

nt1m commented Aug 7, 2023

nt1m commented Aug 8, 2023

nt1m commented Aug 8, 2023

nt1m commented Aug 8, 2023 •

edited

Loading

mfreed7 commented Aug 9, 2023

mfreed7 left a comment

mfreed7 left a comment

nt1m commented Aug 21, 2023

domenic left a comment

annevk commented Aug 24, 2023

nt1m commented Aug 26, 2023

Spec :user-invalid & :user-valid #9047

Spec :user-invalid & :user-valid #9047

Conversation

nt1m commented Mar 17, 2023 • edited by pr-preview bot Loading

annevk left a comment

Choose a reason for hiding this comment

mfreed7 left a comment

Choose a reason for hiding this comment

mfreed7 Mar 31, 2023

Choose a reason for hiding this comment

nt1m Mar 31, 2023

Choose a reason for hiding this comment

mfreed7 Mar 31, 2023

Choose a reason for hiding this comment

mfreed7 commented Mar 31, 2023

nt1m commented Mar 31, 2023 • edited Loading

mfreed7 commented Mar 31, 2023

mfreed7 commented May 25, 2023

nt1m commented May 25, 2023

mfreed7 commented May 30, 2023

nt1m commented Jun 13, 2023

mfreed7 commented Aug 1, 2023

nt1m commented Aug 7, 2023

nt1m commented Aug 8, 2023

nt1m commented Aug 8, 2023

nt1m commented Aug 8, 2023 • edited Loading

mfreed7 commented Aug 9, 2023

mfreed7 left a comment

Choose a reason for hiding this comment

mfreed7 left a comment

Choose a reason for hiding this comment

nt1m commented Aug 21, 2023

domenic left a comment

Choose a reason for hiding this comment

annevk commented Aug 24, 2023

nt1m commented Aug 26, 2023

nt1m commented Mar 17, 2023 •

edited by pr-preview bot

Loading

nt1m commented Mar 31, 2023 •

edited

Loading

nt1m commented Aug 8, 2023 •

edited

Loading