Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dom-focus to specify the inline and block arguments to scroll a target into view #9527

Merged
merged 2 commits into from
Jul 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -3940,7 +3940,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<li><dfn data-x-href="https://drafts.csswg.org/cssom-view/#document-run-the-resize-steps">run the resize steps</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/cssom-view/#document-run-the-scroll-steps">run the scroll steps</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/cssom-view/#evaluate-media-queries-and-report-changes">evaluate media queries and report changes</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/cssom-view/#scroll-an-element-into-view">Scroll an element into view</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/cssom-view/#scroll-a-target-into-view">Scroll a target into view</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/cssom-view/#scroll-to-the-beginning-of-the-document">Scroll to the beginning of the document</dfn></li>
<li>The <dfn data-x="event-resize" data-x-href="https://drafts.csswg.org/cssom-view/#eventdef-window-resize"><code>resize</code></dfn> event</li>
<li>The <dfn data-x="event-scroll" data-x-href="https://drafts.csswg.org/cssom-view/#eventdef-document-scroll"><code>scroll</code></dfn> event</li>
Expand Down Expand Up @@ -67678,7 +67678,7 @@ try {
<li><p>Let <var>notionalChild</var> be a hypothetical element that is a rendered child of the
<code>canvas</code> element whose dimensions are those of <var>specifiedRectangle</var>.</p></li>

<li><p><span data-x="scroll an element into view">Scroll <var>notionalChild</var> into
<li><p><span data-x="scroll a target into view">Scroll <var>notionalChild</var> into
view</span> with <var>behavior</var> set to "auto", <var>block</var> set to "start", and
<var>inline</var> set to "nearest".</p>

Expand Down Expand Up @@ -78968,10 +78968,8 @@ partial interface <span id="NavigatorUserActivation-partial">Navigator</span> {

<li><p>If the value of the <dfn dict-member for="FocusOptions"><code
data-x="dom-focusoptions-preventscroll">preventScroll</code></dfn> dictionary member of
<var>options</var> is false, then <span data-x="scroll an element into view">scroll the element
into view</span> with scroll behavior "<code data-x="">auto</code>", block flow direction
position set to an <span>implementation-defined</span> value, and inline base direction position
set to an <span>implementation-defined</span> value.</p></li>
<var>options</var> is false, then <span data-x="scroll a target into view">scroll the element
into view</span> given "auto", "center", and "center".</p></li>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here you could update this to modern style, which would be given "auto", "center", and "center". (Since the algorithm is not declared with named parameters.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good point

<li><p>Unmark the element as <i data-x="locked for focus">locked for focus</i>.</p></li>
</ol>
Expand Down Expand Up @@ -99739,7 +99737,7 @@ location.href = '#foo';</code></pre>
<li><p>Run the <span>ancestor hidden-until-found revealing algorithm</span> on
<var>target</var>.</p></li>

<li><p><span data-x="scroll an element into view">Scroll <var>target</var> into view</span>,
<li><p><span data-x="scroll a target into view">Scroll <var>target</var> into view</span>,
with <var>behavior</var> set to "auto", <var>block</var> set to "start", and <var>inline</var>
set to "nearest". <ref spec=CSSOMVIEW></p></li>

Expand Down