Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove erroneous break in hide popover algorithm #9528

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Remove erroneous break in hide popover algorithm #9528

merged 1 commit into from
Jul 25, 2023

Conversation

josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Jul 17, 2023 •
edited by pr-preview bot
Loading

Fixes #9468

I mistakenly added and modified this check while speccing a chromium patch in this PR: #9198

  • At least two implementers are interested (and none opposed):
    • Chrome already implements
    • WebKit already implements
  • Tests are written and can be reviewed and commented upon at:
    • No tests were added for this erroneous break in the first place
  • Implementation bugs are filed:
    • Chromium: Already implemented
    • Gecko: I believe that gecko doesn't have this break in it, so no changes are needed? @mbrodesser-Igalia am I right?
    • WebKit: Already implemented

(See WHATWG Working Mode: Changes for more details.)

/popover.html ( diff )

@josepharhar
Remove erroneous break in hide popover algorithm
f679518 
Fixes whatwg#9468

I mistakenly added and modified this check while speccing a chromium
patch in this PR: whatwg#9198
@josepharhar josepharhar mentioned this pull request Jul 17, 2023
Closed
@domenic domenic added the topic: popover The popover attribute and friends label Jul 24, 2023
@annevk annevk merged commit eed5c0e into whatwg:main Jul 25, 2023
@YusukeHirao YusukeHirao mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
topic: popover The popover attribute and friends
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should step 7 of https://html.spec.whatwg.org/#hide-popover-algorithm be a while loop?
3 participants
@josepharhar @annevk @domenic