Add bandwidth shaping support

[neutronth]

Features:

• Per client bandwidth shaping with default setting.
• Per client bandwidth shaping with per client setting get from
  authen server.
• Gateway speed limit. (gateway bandwidth shaping)

Notes:
OpenWRT requires these packages,
* tc
* kmod-ifb
* kmod-sched (sch_htb, sch_codel)
* kmod-sched-core (act_mirred)

[mhaas]

I looked over this rather quickly before bed and I have to say: this is really good.

Just a question: is it possible to have a restriction of the total bandwidth without limiting individual clients? From the config description, I guess it is possible.

[neutronth]

Yes, it is possible. Sorry that it's not clearly mentioned in the config description.
You could apply the total bandwidth limit without limiting individual clients by this settings

== 8< ==
BandwidthShaping yes
BandwidthShapingGatewaySpeedLimit yes
BandwidthGatewayMaxDown 102400
BandwidthGatewayMaxUp 102400
BandwidthDefaultClientMaxDown 0 <= set it to 0 for no limit (no bandwidth shaping apply)
BandwidthDefaultClientMaxUp 0 <= set it to 0 for no limit
== 8< ==

or drop the "BandwidthDefaultClientMax{Down,Up}" from the config file as it's default value is 0

[KazukiShimada]

nice feature!
This patch includes #206?

[mhaas]

I want to merge this. I hope to test this next weekend when I'll have some more time.

[mhaas]

Wouldn't you need to check the return code here?

[mhaas]

I have added some comments to the code. It's really good even including my minor nitpicks.

From an OpenWrt packager's perspective: since traffic shaping is available by default (albeit not necessarily configured), an OpenWrt should probably include dependencies on tc and related kernel modules. That's probably quite a big dependency for an embedded system.

I see two possible solutions here:

• Add a --enable-traffic-shaping configure option and provide an additional package (wifidog-shaping) for those who need the feature
• Add run-time checks for the presence of the tc binary and tell the user he needs to install additional packages. Then the OpenWrt packager wouldn't need to create yet another Wifidog sub-package.

[imnobodyet]

nice work! compiled and worked fine for client speed limiting, but with few issues:

1. "wdctl restart" will reset the bw parameters to 0 for each client, additional settings during the clients transferring would fix this.
2. The BandwidthShapingGatewaySpeedLimit seems not working, i.e
   a. gatewaymaxdown=1024 and clientmaxdown=2048 and the client get 2048kbps.
   b. gatewaymaxdown=1524 and clientmaxdown=1024 and 2 clients can both get 1024kbps.
   and gatewaymaxdown/up cannot be 0. But I was not using standard LAN-WAN interfaces, I used eth0 as WAN and eth0.5 as LAN (also the gatewayinterface in wifidog) , I'll try two physical interfaces next time

[qianguozheng]

So, what's current status ? who will do the suggestions ?

[mhaas]

@qianguozheng I was hoping for @neutronth to tackle the improvements and bug fixes. It will be several weeks at least before I can commit any time :(