Avoid DB access in non-Database tests

When possible, mock the services which access the DB (one notable
example is ChangeTagsStore in many API tests), or provide explicitly the
data that would be looked up in the DB (e.g., Title content model). Add
the test to the Database group otherwise.

Change-Id: Icb3b3ad726bdcfcb64186cf2644d6d2bf3041c78

client/tests/phpunit/integration/includes/Hooks/ParserOutputUpdateHookHandlerTest.php

@@ -44,6 +44,7 @@
 use Wikibase\Lib\SettingsArray;
 use Wikibase\Lib\Store\SiteLinkLookup;
 use Wikibase\Lib\Tests\MockRepository;
+use Wikimedia\TestingAccessWrapper;
 
 /**
  * @covers \Wikibase\Client\Hooks\ParserOutputUpdateHookHandler
@@ -320,6 +321,8 @@ public function testDoContentAlterParserOutput(
 		array $expectedSisterLinks,
 		array $expectedBadges = null
 	) {
+		$titleWrapper = TestingAccessWrapper::newFromObject( $title );
+		$titleWrapper->mRedirect = false;
 		$content = $this->createMock( Content::class );
 		$parserOutput = $this->newParserOutput( $extensionDataAppend, [] );
 		$handler = $this->newParserOutputUpdateHookHandler( $this->getTestSiteLinkData() );
@@ -420,6 +423,8 @@ public function testGivenSitelinkHasStatementWithUnknownEntityType_linkDataIsAdd
 
 		$content = $this->createMock( Content::class );
 		$title = Title::makeTitle( NS_MAIN, 'Foobarium' );
+		$titleWrapper = TestingAccessWrapper::newFromObject( $title );
+		$titleWrapper->mRedirect = false;
 
 		$parserOutput = $this->newParserOutput( [], [] );
 

lib/tests/phpunit/Formatters/AutoCommentFormatterTest.php

@@ -58,6 +58,8 @@ public static function provideTestAutoComment() {
 	 * @dataProvider provideTestAutoComment
 	 */
 	public function testFormatAutoComment( array $prefixes, $auto, $expected ) {
+		// If the Translate extension is installed, its handler for ParserBeforeInternalParse can trigger DB access
+		$this->clearHook( 'ParserBeforeInternalParse' );
 		$formatter = new AutoCommentFormatter( $this->language, $prefixes );
 		$value = $formatter->formatAutoComment( $auto );
 		$this->assertEquals( $expected, $value );

repo/rest-api/tests/phpunit/RouteHandlers/AddItemStatementRouteHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\RestApi\RouteHandlers;
 
+use MediaWiki\ChangeTags\ChangeTagsStore;
 use MediaWiki\Rest\Handler;
 use MediaWiki\Rest\Reporter\ErrorReporter;
 use MediaWiki\Rest\RequestData;
@@ -23,6 +24,13 @@ class AddItemStatementRouteHandlerTest extends MediaWikiIntegrationTestCase {
 
 	use HandlerTestTrait;
 
+	protected function setUp(): void {
+		parent::setUp();
+		$changeTagsStore = $this->createMock( ChangeTagsStore::class );
+		$changeTagsStore->method( 'listExplicitlyDefinedTags' )->willReturn( [] );
+		$this->setService( 'ChangeTagsStore', $changeTagsStore );
+	}
+
 	public function testHandlesUnexpectedErrors(): void {
 		$useCase = $this->createStub( AddItemStatement::class );
 		$useCase->method( 'execute' )->willThrowException( new RuntimeException() );

repo/rest-api/tests/phpunit/RouteHandlers/GetItemStatementRouteHandlerTest.php

@@ -21,6 +21,7 @@
  * @covers \Wikibase\Repo\RestApi\RouteHandlers\GetItemStatementRouteHandler
  *
  * @group Wikibase
+ * @group Database
  *
  * @license GPL-2.0-or-later
  */

repo/rest-api/tests/phpunit/RouteHandlers/GetPropertyStatementRouteHandlerTest.php

@@ -20,6 +20,7 @@
  * @covers \Wikibase\Repo\RestApi\RouteHandlers\GetPropertyStatementRouteHandler
  *
  * @group Wikibase
+ * @group Database
  *
  * @license GPL-2.0-or-later
  */

repo/rest-api/tests/phpunit/RouteHandlers/PatchItemLabelsRouteHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\RestApi\RouteHandlers;
 
+use MediaWiki\ChangeTags\ChangeTagsStore;
 use MediaWiki\Rest\Handler;
 use MediaWiki\Rest\Reporter\ErrorReporter;
 use MediaWiki\Rest\RequestData;
@@ -23,6 +24,13 @@ class PatchItemLabelsRouteHandlerTest extends MediaWikiIntegrationTestCase {
 
 	use HandlerTestTrait;
 
+	protected function setUp(): void {
+		parent::setUp();
+		$changeTagsStore = $this->createMock( ChangeTagsStore::class );
+		$changeTagsStore->method( 'listExplicitlyDefinedTags' )->willReturn( [] );
+		$this->setService( 'ChangeTagsStore', $changeTagsStore );
+	}
+
 	public function testHandlesUnexpectedErrors(): void {
 		$useCase = $this->createStub( PatchItemLabels::class );
 		$useCase->method( 'execute' )->willThrowException( new RuntimeException() );

repo/rest-api/tests/phpunit/RouteHandlers/PatchItemStatementRouteHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\RestApi\RouteHandlers;
 
+use MediaWiki\ChangeTags\ChangeTagsStore;
 use MediaWiki\Rest\Handler;
 use MediaWiki\Rest\Reporter\ErrorReporter;
 use MediaWiki\Rest\RequestData;
@@ -23,6 +24,13 @@ class PatchItemStatementRouteHandlerTest extends MediaWikiIntegrationTestCase {
 
 	use HandlerTestTrait;
 
+	protected function setUp(): void {
+		parent::setUp();
+		$changeTagsStore = $this->createMock( ChangeTagsStore::class );
+		$changeTagsStore->method( 'listExplicitlyDefinedTags' )->willReturn( [] );
+		$this->setService( 'ChangeTagsStore', $changeTagsStore );
+	}
+
 	public function testHandlesUnexpectedErrors(): void {
 		$useCase = $this->createStub( PatchItemStatement::class );
 		$useCase->method( 'execute' )->willThrowException( new RuntimeException() );

repo/rest-api/tests/phpunit/RouteHandlers/PatchStatementRouteHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\RestApi\RouteHandlers;
 
+use MediaWiki\ChangeTags\ChangeTagsStore;
 use MediaWiki\Rest\Handler;
 use MediaWiki\Rest\Reporter\ErrorReporter;
 use MediaWiki\Rest\RequestData;
@@ -23,6 +24,13 @@ class PatchStatementRouteHandlerTest extends MediaWikiIntegrationTestCase {
 
 	use HandlerTestTrait;
 
+	protected function setUp(): void {
+		parent::setUp();
+		$changeTagsStore = $this->createMock( ChangeTagsStore::class );
+		$changeTagsStore->method( 'listExplicitlyDefinedTags' )->willReturn( [] );
+		$this->setService( 'ChangeTagsStore', $changeTagsStore );
+	}
+
 	public function testHandlesUnexpectedErrors(): void {
 		$useCase = $this->createStub( PatchItemStatement::class );
 		$useCase->method( 'execute' )->willThrowException( new RuntimeException() );

repo/rest-api/tests/phpunit/RouteHandlers/RemoveItemStatementRouteHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\RestApi\RouteHandlers;
 
+use MediaWiki\ChangeTags\ChangeTagsStore;
 use MediaWiki\Rest\Handler;
 use MediaWiki\Rest\Reporter\ErrorReporter;
 use MediaWiki\Rest\RequestData;
@@ -23,6 +24,13 @@ class RemoveItemStatementRouteHandlerTest extends MediaWikiIntegrationTestCase {
 
 	use HandlerTestTrait;
 
+	protected function setUp(): void {
+		parent::setUp();
+		$changeTagsStore = $this->createMock( ChangeTagsStore::class );
+		$changeTagsStore->method( 'listExplicitlyDefinedTags' )->willReturn( [] );
+		$this->setService( 'ChangeTagsStore', $changeTagsStore );
+	}
+
 	public function testHandlesUnexpectedErrors(): void {
 		$useCase = $this->createStub( RemoveItemStatement::class );
 		$useCase->method( 'execute' )->willThrowException( new RuntimeException() );

repo/rest-api/tests/phpunit/RouteHandlers/RemoveStatementRouteHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\RestApi\RouteHandlers;
 
+use MediaWiki\ChangeTags\ChangeTagsStore;
 use MediaWiki\Rest\Handler;
 use MediaWiki\Rest\Reporter\ErrorReporter;
 use MediaWiki\Rest\RequestData;
@@ -23,6 +24,13 @@ class RemoveStatementRouteHandlerTest extends MediaWikiIntegrationTestCase {
 
 	use HandlerTestTrait;
 
+	protected function setUp(): void {
+		parent::setUp();
+		$changeTagsStore = $this->createMock( ChangeTagsStore::class );
+		$changeTagsStore->method( 'listExplicitlyDefinedTags' )->willReturn( [] );
+		$this->setService( 'ChangeTagsStore', $changeTagsStore );
+	}
+
 	public function testHandlesUnexpectedErrors(): void {
 		$useCase = $this->createStub( RemoveItemStatement::class );
 		$useCase->method( 'execute' )->willThrowException( new RuntimeException() );

repo/rest-api/tests/phpunit/RouteHandlers/ReplaceItemStatementRouteHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\RestApi\RouteHandlers;
 
+use MediaWiki\ChangeTags\ChangeTagsStore;
 use MediaWiki\Rest\Handler;
 use MediaWiki\Rest\Reporter\ErrorReporter;
 use MediaWiki\Rest\RequestData;
@@ -24,6 +25,13 @@ class ReplaceItemStatementRouteHandlerTest extends MediaWikiIntegrationTestCase
 
 	use HandlerTestTrait;
 
+	protected function setUp(): void {
+		parent::setUp();
+		$changeTagsStore = $this->createMock( ChangeTagsStore::class );
+		$changeTagsStore->method( 'listExplicitlyDefinedTags' )->willReturn( [] );
+		$this->setService( 'ChangeTagsStore', $changeTagsStore );
+	}
+
 	public function testHandlesUnexpectedErrors(): void {
 		$useCase = $this->createStub( ReplaceStatement::class );
 		$useCase->method( 'execute' )->willThrowException( new RuntimeException() );

repo/rest-api/tests/phpunit/RouteHandlers/ReplaceStatementRouteHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\RestApi\RouteHandlers;
 
+use MediaWiki\ChangeTags\ChangeTagsStore;
 use MediaWiki\Rest\Handler;
 use MediaWiki\Rest\Reporter\ErrorReporter;
 use MediaWiki\Rest\RequestData;
@@ -23,6 +24,13 @@ class ReplaceStatementRouteHandlerTest extends MediaWikiIntegrationTestCase {
 
 	use HandlerTestTrait;
 
+	protected function setUp(): void {
+		parent::setUp();
+		$changeTagsStore = $this->createMock( ChangeTagsStore::class );
+		$changeTagsStore->method( 'listExplicitlyDefinedTags' )->willReturn( [] );
+		$this->setService( 'ChangeTagsStore', $changeTagsStore );
+	}
+
 	public function testHandlesUnexpectedErrors(): void {
 		$useCase = $this->createStub( ReplaceStatement::class );
 		$useCase->method( 'execute' )->willThrowException( new RuntimeException() );

repo/rest-api/tests/phpunit/RouteHandlers/SetItemDescriptionRouteHandlerTest.php

@@ -14,6 +14,7 @@
 /**
  * @covers \Wikibase\Repo\RestApi\RouteHandlers\SetItemDescriptionRouteHandler
  * @group Wikibase
+ * @group Database
  * @license GPL-2.0-or-later
  */
 class SetItemDescriptionRouteHandlerTest extends \MediaWikiIntegrationTestCase {

repo/rest-api/tests/phpunit/RouteHandlers/SetItemLabelRouteHandlerTest.php

@@ -14,6 +14,7 @@
 /**
  * @covers \Wikibase\Repo\RestApi\RouteHandlers\SetItemLabelRouteHandler
  * @group Wikibase
+ * @group Database
  * @license GPL-2.0-or-later
  */
 class SetItemLabelRouteHandlerTest extends \MediaWikiIntegrationTestCase {

repo/tests/phpunit/includes/Api/QuerySearchEntitiesTest.php

@@ -7,6 +7,7 @@
 use ApiPageSet;
 use ApiQuery;
 use MediaWiki\Request\FauxRequest;
+use MediaWiki\Tests\Unit\Permissions\MockAuthorityTrait;
 use MediaWikiIntegrationTestCase;
 use RequestContext;
 use Status;
@@ -32,6 +33,7 @@
  * @author Bene* < [email protected] >
  */
 class QuerySearchEntitiesTest extends MediaWikiIntegrationTestCase {
+	use MockAuthorityTrait;
 
 	/**
 	 * @param array $params
@@ -42,6 +44,7 @@ private function getApiQuery( array $params ) {
 		$context = new RequestContext();
 		$context->setLanguage( 'en-ca' );
 		$context->setRequest( new FauxRequest( $params, true ) );
+		$context->setAuthority( $this->mockRegisteredNullAuthority() );
 		$main = new ApiMain( $context );
 		return $main->getModuleManager()->getModule( 'query' );
 	}

repo/tests/phpunit/includes/Content/EntityHandlerTestCase.php

@@ -8,7 +8,9 @@
 use DataValues\Serializers\DataValueSerializer;
 use DummySearchIndexFieldDefinition;
 use InvalidArgumentException;
+use LinkBatch;
 use LogicException;
+use MediaWiki\Cache\LinkBatchFactory;
 use MediaWiki\MediaWikiServices;
 use MediaWiki\Revision\RevisionRecord;
 use MediaWiki\Revision\SlotRecord;
@@ -17,6 +19,7 @@
 use RuntimeException;
 use SearchEngine;
 use Serializers\Serializer;
+use Site;
 use Title;
 use Wikibase\DataAccess\DatabaseEntitySource;
 use Wikibase\DataAccess\EntitySourceDefinitions;
@@ -56,6 +59,7 @@ protected function setUp(): void {
 			'WikibaseRepo.EntityTypeDefinitions',
 			$this->getEntityTypeDefinitions()
 		);
+		$this->setService( 'WikibaseClient.SiteGroup', Site::GROUP_NONE );
 	}
 
 	abstract public function getModelId();
@@ -720,7 +724,13 @@ public function providePageProperties() {
 	 * @dataProvider providePageProperties
 	 */
 	public function testPageProperties( EntityContent $content, array $expectedProps ) {
+		$lb = $this->createMock( LinkBatch::class );
+		$lb->method( 'doQuery' )->willReturn( false );
+		$lbFactory = $this->createMock( LinkBatchFactory::class );
+		$lbFactory->method( 'newLinkBatch' )->willReturn( $lb );
+		$this->setService( 'LinkBatchFactory', $lbFactory );
 		$title = Title::makeTitle( NS_MAIN, 'Foo' );
+		$title->setContentModel( CONTENT_MODEL_WIKITEXT );
 		$contentRenderer = $this->getServiceContainer()->getContentRenderer();
 		$parserOutput = $contentRenderer->getParserOutput( $content, $title, null, null, false );
 

repo/tests/phpunit/includes/Content/PropertyHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Wikibase\Repo\Tests\Content;
 
+use MediaWiki\Page\WikiPageFactory;
 use ParserOutput;
 use Title;
 use Wikibase\DataModel\Entity\EntityDocument;
@@ -25,6 +26,7 @@
  * @group WikibaseProperty
  * @group WikibaseEntity
  * @group WikibaseEntityHandler
+ * @group Database
  *
  * @license GPL-2.0-or-later
  * @author Jeroen De Dauw < [email protected] >
@@ -196,10 +198,12 @@ public function testDataForSearchIndex() {
 	}
 
 	public function testGetParserOutput() {
+		$this->setService( 'WikiPageFactory', $this->createMock( WikiPageFactory::class ) );
 		$content = $this->newEntityContent();
 		$contentRenderer = $this->getServiceContainer()->getContentRenderer();
 
 		$title = Title::makeTitle( NS_MAIN, 'Foo' );
+		$title->setContentModel( CONTENT_MODEL_WIKITEXT );
 		$parserOutput = $contentRenderer->getParserOutput( $content, $title );
 
 		$expectedUsedOptions = [ 'userlang', 'wb', 'termboxVersion' ];

repo/tests/phpunit/includes/FederatedProperties/Hooks/HtmlPageLinkRendererEndHookHandlerTest.php

@@ -11,6 +11,7 @@
 use Wikibase\DataModel\Entity\Property;
 use Wikibase\Repo\FederatedProperties\ApiRequestExecutionException;
 use Wikibase\Repo\Tests\Hooks\HtmlPageLinkRendererEndHookHandlerTestBase;
+use Wikimedia\TestingAccessWrapper;
 
 /**
  * @covers \Wikibase\Repo\Hooks\HtmlPageLinkRendererEndHookHandler
@@ -28,6 +29,8 @@ public function testDoHtmlPageLinkRendererBegin( LinkRenderer $linkRenderer, Req
 		$handler = $this->newInstance( 'foo', false, true, Property::ENTITY_TYPE );
 
 		$title = Title::makeTitle( WB_NS_PROPERTY, self::PROPERTY_WITH_LABEL );
+		$wrapper = TestingAccessWrapper::newFromObject( $title );
+		$wrapper->mRedirect = false;
 		$text = $title->getFullText();
 		$customAttribs = [];
 

repo/tests/phpunit/includes/FederatedProperties/ParserOutput/FederatedPropertiesPrefetchingEntityParserOutputGeneratorDecoratorTest.php

@@ -3,6 +3,8 @@
 declare( strict_types = 1 );
 namespace Wikibase\Repo\Tests\FederatedProperties\ParserOutput;
 
+use LinkBatch;
+use MediaWiki\Cache\LinkBatchFactory;
 use Psr\SimpleCache\CacheInterface;
 use RepoGroup;
 use Wikibase\DataModel\Entity\EntityId;
@@ -34,6 +36,12 @@
 class FederatedPropertiesPrefetchingEntityParserOutputGeneratorDecoratorTest extends EntityParserOutputGeneratorTestBase {
 
 	public function testShouldPrefetchFederatedProperties() {
+		$lb = $this->createMock( LinkBatch::class );
+		$lb->method( 'doQuery' )->willReturn( false );
+		$lbFactory = $this->createMock( LinkBatchFactory::class );
+		$lbFactory->method( 'newLinkBatch' )->willReturn( $lb );
+		$this->setService( 'LinkBatchFactory', $lbFactory );
+
 		$labelLanguage = 'en';
 
 		$fedPropId1 = new FederatedPropertyId( 'http://wikidata.org/entity/P123', 'P123' );

repo/tests/phpunit/includes/Hooks/MakeGlobalVariablesScriptHookHandlerTest.php

@@ -18,6 +18,7 @@
  * @covers \Wikibase\Repo\Hooks\MakeGlobalVariablesScriptHookHandler
  *
  * @group Wikibase
+ * @group Database
  *
  * @license GPL-2.0-or-later
  */

repo/tests/phpunit/includes/Rdf/RdfBuilderTest.php

@@ -46,6 +46,7 @@
  *
  * @group Wikibase
  * @group WikibaseRdf
+ * @group Database
  *
  * @license GPL-2.0-or-later
  * @author Daniel Kinzler