Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified the version string parser #2244

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Simplified the version string parser #2244

merged 2 commits into from
Jul 7, 2023

Conversation

breiler
Copy link
Collaborator

@breiler breiler commented Jul 7, 2023

Simplified the version string parser to just getting the major, minor and patch character from the version string.

@breiler breiler merged commit 589ef4f into master Jul 7, 2023
1 check passed
@bLouChip
Copy link

bLouChip commented Jul 8, 2023

The latest nightly build snapshot with this fix worked first time every time that I attempted a USB connection.
Thank you for handling so quickly. well done.
console results [partial] upon connection...

*** Connecting to jserialcomm://COM3:115200
Grbl 1.1i MR MegaV bLouChip Tri-CAM Open Frame Bed ['$' for help]
>>> ?
ok
>>> $I
[VER:1.1i MR MegaV bLouChip Tri-CAM Open Frame Bed.V4-20230217:]
[AXS:4:XYZA]
[OPT:VNMPHRL,35,255]
ok
$$ report followed...

@breiler breiler deleted the bugfix/version-string branch July 11, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants