-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a default INSTALLFOLDER. #435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnson
force-pushed
the
bob/DefaultInstallFolder
branch
2 times, most recently
from
December 23, 2023 22:46
c6b70db
to
40b4cc6
Compare
barnson
added a commit
that referenced
this pull request
Dec 24, 2023
Add Package/@UpgradeStrategy to allow `none` to suppress major upgrade. Implements wixtoolset/issues#7605. Requires #435.
robmen
requested changes
Dec 26, 2023
barnson
force-pushed
the
bob/DefaultInstallFolder
branch
3 times, most recently
from
December 27, 2023 01:30
37d3a96
to
be3991f
Compare
robmen
requested changes
Dec 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subtle things that if resolved, I think this is good to go.
If INSTALLFOLDER is referenced and not defined, define one with reasonable default values. Implements WIP wixtoolset/issues#7588.
barnson
force-pushed
the
bob/DefaultInstallFolder
branch
from
December 29, 2023 21:30
be3991f
to
96eeebe
Compare
barnson
added a commit
that referenced
this pull request
Dec 29, 2023
Add Package/@UpgradeStrategy to allow `none` to suppress major upgrade. Implements wixtoolset/issues#7605. Requires #435.
robmen
approved these changes
Dec 30, 2023
W00t. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If INSTALLFOLDER is referenced and not defined, define one with reasonable default values.
Implements WIP wixtoolset/issues#7588.