Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new market data for osnabrueck #203

Merged
merged 1 commit into from
May 9, 2017
Merged

add new market data for osnabrueck #203

merged 1 commit into from
May 9, 2017

Conversation

BjoernSchilberg
Copy link
Contributor

I added the markets from Osnabrück.

@@ -175,6 +175,10 @@
"id": "oldenburg",
"label": "Oldenburg (Oldb)"
},
"osnabrueck": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your contribution. Please note that we support German Umlauts as mentioned in the contribution guide. Please rename osnabrueck.json to osnabrück.json and adapt the change in cities.json as follows:

"osnabrück": {
    "id": "osnabrück",
    "label": "Osnabrück"
},

You are welcome to update this pull request. You can update your commit using git commit --amend and then update the branch on GitHub via git push --force market-data-osnabrueck. Let me know if you need help in any case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the hint.

@johnjohndoe johnjohndoe self-assigned this May 9, 2017
@johnjohndoe johnjohndoe merged commit d64ff22 into wo-ist-markt:master May 9, 2017
@johnjohndoe
Copy link
Member

@BjoernSchilberg I appreciate the nice and clean pull request and I like to welcome you on Wo ist Markt? 💐

In order to promote the project I would like to ask you for two follow up tasks:

  • Send a tweet #woistmarkt with a screenshot and a link to the website (please share the tweet link here)
  • Try to convince the city of Osnabrück to link to our website, see Promote website #38

You are also very welcome to improve the code. Please take a look at our issue tracker.

@BjoernSchilberg BjoernSchilberg deleted the market-data-osnabrueck branch May 9, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants