Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add market data for Stuttgart #286

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Mar 20, 2019

Data source was Stuttgarter Wochenmärkte. However, as coordinates were mostly not included in the source and the displayed coordinates sometimes a bit off, I used OSM to retrieve them.

To cite OSM as data_source, I added a new data_source_coords. To refer to the underlying OSM features, I added an osm_id, where a corresponding feature exists. Please check if you are ok with this.

Copy link
Member

@johnjohndoe johnjohndoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hbruch. Can you please check your coordinates - here is a preview - you can find the updated link at the end of your pull request.

README.md Show resolved Hide resolved
cities/stuttgart.json Outdated Show resolved Hide resolved
@johnjohndoe johnjohndoe self-assigned this Mar 21, 2019
@johnjohndoe johnjohndoe merged commit 8512725 into wo-ist-markt:master Mar 21, 2019
@johnjohndoe
Copy link
Member

@hbruch Thanks a lot for adding Stuttgart 🍷

Please note that I squashed your commits into one. In case you want to keep the OpenStreetMap information I pushed the temporary stuttgart-openstreetmap branch. Please take the commits to your fork and let me know when I can remove it here.

As usual here are the follow-up tasks to promote the project/website:

  • Send a tweet #woistmarkt with a screenshot and a link to the website (please share the tweet link here)
  • Try to convince the city of Stuttgart to link to our website, see Promote website #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants